Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action] app_store_build_number: Pass teamID when selecting itunes team #14604

Merged
merged 3 commits into from Apr 19, 2019
Merged

[action] app_store_build_number: Pass teamID when selecting itunes team #14604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
901fe79
Pass teamID when selecting itunes team
Apr 16, 2019
66164f3
Pass team name when selecting itunes team
Apr 18, 2019
d0160eb
Remove setting team id and name env vars when parameters are passed
Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastlane/lib/fastlane/actions/app_store_build_number.rb
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ def self.run(params)
def self.get_build_number(params)
UI.message("Login to App Store Connect (#{params[:username]})")
Spaceship::Tunes.login(params[:username])
Spaceship::Tunes.select_team
Spaceship::Tunes.select_team(team_id: params[:team_id], team_name: params[:team_name])
UI.message("Login successful")

app = Spaceship::Tunes::Application.find(params[:app_identifier])
Expand Down
10 changes: 2 additions & 8 deletions fastlane/lib/fastlane/actions/latest_testflight_build_number.rb
View file
Open in desktop
Expand Up @@ -79,21 +79,15 @@ def self.available_options
is_string: false, # as we also allow integers, which we convert to strings anyway
code_gen_sensitive: true,
default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id),
default_value_dynamic: true,
verify_block: proc do |value|
ENV["FASTLANE_ITC_TEAM_ID"] = value.to_s
end),
default_value_dynamic: true),
FastlaneCore::ConfigItem.new(key: :team_name,
short_option: "-e",
env_name: "LATEST_TESTFLIGHT_BUILD_NUMBER_TEAM_NAME",
description: "The name of your App Store Connect team if you're in multiple teams",
optional: true,
code_gen_sensitive: true,
default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_name),
default_value_dynamic: true,
verify_block: proc do |value|
ENV["FASTLANE_ITC_TEAM_NAME"] = value.to_s
end)
default_value_dynamic: true)
]
end

Expand Down