[action] Added format option to swiftlint action
#14643
Conversation
janpio
changed the title
format option to swiftlint actionformat option to swiftlint action
| optional: true) | ||
| optional: true), | ||
| FastlaneCore::ConfigItem.new(key: :format, | ||
| description: "Format code when mode is :autocorrect", |
| optional: true), | ||
| FastlaneCore::ConfigItem.new(key: :format, | ||
| description: "Format code when mode is :autocorrect", | ||
| default_value: false, |
There was a problem hiding this comment.
You can specify type: Boolean,.
fastlane has Boolean type.
| expect(result).to eq("swiftlint lint") | ||
| end | ||
|
|
||
| it "omits the switch if swiftlint version is too low" do |
There was a problem hiding this comment.
too earlier? (I'm not a native speaker)
There was a problem hiding this comment.
It's not right, but I basically copied and pasted. I'm gonna change this.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
Congratulations! 🎉 This was released as part of fastlane 2.122.0 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
This PR adds the option
formattoswiftlintaction.Description
The option is only available for mode
autocorrect, it formats the code besides the changes regarding the rules. If the mode is set tolint, then the option has no effect.