Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add notarize action #15956

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Conversation

berkcebi
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This pull request adds the notarize action from zeplin/fastlane-plugin-notarize, as discussed in zeplin/fastlane-plugin-notarize#22. 🍻

Description

Notarize action uploads an app to Apple's notarization service, querying the result periodically until it's complete—which currently takes around 2 minutes. In case of success, it staples the app with the notarization ticket. In case of failure, it prints the log file listing all the issues.

Note that tests are still missing, cheers!

Add notarize action from https://github.com/zeplin/fastlane-plugin-notarize/

Co-Authored-By: Yigitcan Yurtsever <yigitcanyurtsever@users.noreply.github.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yigitcanyurtsever
Copy link
Contributor

@googlebot I fixed it.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@yigitcanyurtsever
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@janpio
Copy link
Member

janpio commented Feb 1, 2020

Fastlane needs a category for the docs, which CI is complaining about right now:

Unknown action category 'undefined', must be one of testing, building, screenshots, project, code_signing, documentation, beta, push, production, source_control, notifications, app_store_connect, misc, deprecated

Definition looks like this:

def self.category
:misc
end

Probably code_signing is the most appropriate one? Not sure.

@berkcebi
Copy link
Contributor Author

berkcebi commented Feb 3, 2020

code_signing makes sense, added it!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sooooo 🔥 Just got it added to one of my test projects 😊 I really appreciate the code donation ❤️ I'm going to do a bit more testing but this should be merged and released later this week 💪

@joshdholtz joshdholtz changed the title Add notarize action [action] add notarize action Feb 17, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good! Thanks again for this action 😊 ❤️

@joshdholtz joshdholtz merged commit 69ff43c into fastlane:master Feb 17, 2020
@fastlane-bot
Copy link

Hey @berkcebi 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.142.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants