[spaceship] increase timeout for web session connect api to 1200 #16676
Conversation
joshdholtz
deleted the
joshdholtz-2.150.0-update-web-session-connect-api-timeout
branch
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.150.0.rc2 🚀
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.150.0.rc5 🚀
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.150.0.rc6 🚀
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.150.0.rc7 🚀
…ct API endpoints (#16640) * [deliver][produce][spaceship] Update to use new App Store Connect API endpoints (#16626) * Initial commit * Fixed ensuring version at start of deliver and selecting build at the end * Added error message for submission not working yet * Big fix for screenshots and fix for erroring out when not able to activate language * Removal of unused things and fix for explicitly submitting build * Fix for circular reference * Fix for first screenshot * content_rights_contains_third_party_content works for submission information * Updated comment * Quick fix * This should fix all bad state issues * Removed UI from spaceship * fixed submit stuff * Updating categories works holy cow * I think all meta data is working * Whoops. had submit for review commented out * Allowed rejected apps to be edit and only send up whatsNew if live version * rubocop is happy * So many fixes * Fixed validate doc and lint * Fixed and commented out some tests * Added in age rating * ruocoped * Adding back in IDFA because i dont know where it went * Fix produce for app store connect * Removed some pp * One extra line * Update to ConnectAPI usage Adding authorization and retrieving list of apps / find specific app. * [2.150.0][deliver] better error when uses non exempt encryption not set (#16646) * [deliver] fix for better error on uses non exempt encryption * New error messages and fixes of wrong things being set * [2.150.0][deliver] fix category deleting when not specified (#16652) * [deliver] fix category from deleting when not specified * Warn users of deprecated mapped categories * Updated some doc * [deliver] warn about mapped/deprecated age rating values (#16655) * [deliver] warn about mapped/deprecated age rating values * Full in on https * Lots of fixes whoops Co-authored-by: Max Ott <max.ott@me.com> * [deliver][produce] map language names and available countries on app (#16656) * [deliver][produce] map language names and available countries on app * Fix price match and remove comment * [deliver] allow default language for metadata (#16657) * [action] fix set_changelog (#16658) * [deliver][spaceship] multi-thread delete screenshots and retry on 504 (#16667) * [deliver][spaceship] multi-thread delete screenshots and retry on 504 * Improved error handling * Fix tests * [spaceship] add app preview (#16671) * [spaceship] add app preview * Added new preview devices * [spaceship] increase timeout for web session connect api to 1200 (#16676) * Version bump 2.150.0.rc2 * Fix to make produce create on ASC work again * [spaceship] waiting_for_review is editable (ish) (#16680) * [spaceship] waiting_for_review is editable (ish) * Added for app store version too * [spaceship] retry file uploader and poll app preview to set frame (#16684) * [spaceship] retry file uploader and poll app preview to set frame * Some doc cleanup * Handle fail logic if patch retries on file upload and fix mapping of age category * Raise error if all failed * [spaceship][fastlane_core] run itmstransporter with xcrun if xcode 11 or up (#16689) * [deliver][spaceship] fix 500 with appInfos and skip already uploaded screenshots with deliver (#16694) * Version bump to 2.150.0.rc4 * [produce][spaceship] add users to app when created (#16695) * [produce][spaceship] add users to app when created * Also add company name * Updated docs on how to use submission (#16706) * [deliver][spaceship] wait for screenshots to be completed after processing and download properly formatted screenshots and error on processing error (#16709) * [deliver][spaceship] choose highest edit version, retry on 500, submit without app version (#16713) * 2.150.0.rc5 bump * [deliver] give better error message when edit or live version is not found when downloading screenshots (#16714) * 2.150.0.rc6 bump * [deliver] fix first version logic now uses number of versions, reject_if_possible, and automatic_release_date uses ms again (#16715) * [deliver] fix first version logic now uses number of versions * Fix deliver reject and fix automatic release date to use time in ms * 2.150.0.rc7 bump * [spaceship] reorder app screenshots in AppScreenshotSet (#16718) * [deliver] fix deliver download screenshot file extension (#16719) * [deliver] fix deliver download screenshot file extension * Updated how skip waiting for processing works * [deliver] fix language detection on upload meta data (#16722) * Reset version to 2.149.0 * Fix for broken review attachment Co-authored-by: Max Ott <max.ott@me.com>
…ct API endpoints (fastlane#16640) * [deliver][produce][spaceship] Update to use new App Store Connect API endpoints (fastlane#16626) * Initial commit * Fixed ensuring version at start of deliver and selecting build at the end * Added error message for submission not working yet * Big fix for screenshots and fix for erroring out when not able to activate language * Removal of unused things and fix for explicitly submitting build * Fix for circular reference * Fix for first screenshot * content_rights_contains_third_party_content works for submission information * Updated comment * Quick fix * This should fix all bad state issues * Removed UI from spaceship * fixed submit stuff * Updating categories works holy cow * I think all meta data is working * Whoops. had submit for review commented out * Allowed rejected apps to be edit and only send up whatsNew if live version * rubocop is happy * So many fixes * Fixed validate doc and lint * Fixed and commented out some tests * Added in age rating * ruocoped * Adding back in IDFA because i dont know where it went * Fix produce for app store connect * Removed some pp * One extra line * Update to ConnectAPI usage Adding authorization and retrieving list of apps / find specific app. * [2.150.0][deliver] better error when uses non exempt encryption not set (fastlane#16646) * [deliver] fix for better error on uses non exempt encryption * New error messages and fixes of wrong things being set * [2.150.0][deliver] fix category deleting when not specified (fastlane#16652) * [deliver] fix category from deleting when not specified * Warn users of deprecated mapped categories * Updated some doc * [deliver] warn about mapped/deprecated age rating values (fastlane#16655) * [deliver] warn about mapped/deprecated age rating values * Full in on https * Lots of fixes whoops Co-authored-by: Max Ott <max.ott@me.com> * [deliver][produce] map language names and available countries on app (fastlane#16656) * [deliver][produce] map language names and available countries on app * Fix price match and remove comment * [deliver] allow default language for metadata (fastlane#16657) * [action] fix set_changelog (fastlane#16658) * [deliver][spaceship] multi-thread delete screenshots and retry on 504 (fastlane#16667) * [deliver][spaceship] multi-thread delete screenshots and retry on 504 * Improved error handling * Fix tests * [spaceship] add app preview (fastlane#16671) * [spaceship] add app preview * Added new preview devices * [spaceship] increase timeout for web session connect api to 1200 (fastlane#16676) * Version bump 2.150.0.rc2 * Fix to make produce create on ASC work again * [spaceship] waiting_for_review is editable (ish) (fastlane#16680) * [spaceship] waiting_for_review is editable (ish) * Added for app store version too * [spaceship] retry file uploader and poll app preview to set frame (fastlane#16684) * [spaceship] retry file uploader and poll app preview to set frame * Some doc cleanup * Handle fail logic if patch retries on file upload and fix mapping of age category * Raise error if all failed * [spaceship][fastlane_core] run itmstransporter with xcrun if xcode 11 or up (fastlane#16689) * [deliver][spaceship] fix 500 with appInfos and skip already uploaded screenshots with deliver (fastlane#16694) * Version bump to 2.150.0.rc4 * [produce][spaceship] add users to app when created (fastlane#16695) * [produce][spaceship] add users to app when created * Also add company name * Updated docs on how to use submission (fastlane#16706) * [deliver][spaceship] wait for screenshots to be completed after processing and download properly formatted screenshots and error on processing error (fastlane#16709) * [deliver][spaceship] choose highest edit version, retry on 500, submit without app version (fastlane#16713) * 2.150.0.rc5 bump * [deliver] give better error message when edit or live version is not found when downloading screenshots (fastlane#16714) * 2.150.0.rc6 bump * [deliver] fix first version logic now uses number of versions, reject_if_possible, and automatic_release_date uses ms again (fastlane#16715) * [deliver] fix first version logic now uses number of versions * Fix deliver reject and fix automatic release date to use time in ms * 2.150.0.rc7 bump * [spaceship] reorder app screenshots in AppScreenshotSet (fastlane#16718) * [deliver] fix deliver download screenshot file extension (fastlane#16719) * [deliver] fix deliver download screenshot file extension * Updated how skip waiting for processing works * [deliver] fix language detection on upload meta data (fastlane#16722) * Reset version to 2.149.0 * Fix for broken review attachment Co-authored-by: Max Ott <max.ott@me.com>
|
@joshdholtz INFO [2020-07-21 07:54:42.12]: Uploading 8 screenshots for language en-US Below is the empty file shows in the appstore. |
|
@joshdholtz |
|
@Thangaraj-M Can you try setting Thanks! |
|
@joshdholtz I will try with increase the timeout. |
|
@joshdholtz I tried again with increase the spaceship timeout value with 1500. But still Timeout error occurred. below is the log. INFO [2020-07-21 20:00:38.90]: Uploading 8 screenshots for language en-US |
|
@joshdholtz The timeout issue occurred at the time of distributing build also. So the whats new value is not updated. below is the log. Here within 2 minutes 5 times retry happened. |
|
@joshdholtz It looks the timeout value is not taken from SPACESHIP_TIMEOUT variable. Could you please say what is wrong? |
|
@Thangaraj-M Can you give this PR a try? #16912 |
|
@joshdholtz I will try this and update the result. |
|
@joshdholtz I updated from the branch and checked again. There was timeout occurred at the time distributing build. Not sure it running from the latest updated branch or the old one. Is there any way to check the build running from new branch or existing one? In the summary it showing 2.152.0 only. |
|
@Thangaraj-M The contents of your |
|
yes. I will reply in that PR |
Motivation and Context
Prevent some timeouts?
Description
Another way to hopefully prevent some timeouts along with the retry