[deliver] fix deliver download screenshot file extension

[joshdholtz]

Motivation and Context

Fixes issue reported by @changusmc (#16639 (comment))

Description

• Extension file grabbing code was bad
  • Replaced with proper way to get extension

Testing Steps

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-2.150.0-fix-deliver-download-extension"

[changusmc]

I'm running it right now, I downloaded all the images using this branch and i'm re-uploading them.

It's been stuck for over 30 minutes.

[09:26:12]: Uploading 'fastlane/metadata_to_test/da/0_APP_IPAD_PRO_129_0.**********.png'...
.

[joshdholtz]

@changusmc App Store Connect might be having some processing issues 😔 They've been a bit up and down about processing images times and image uploads now wait for processing to be complete by default (debating if I want to keep it that way).

But you can set the DELIVER_SKIP_WAIT_FOR_SCREENSHOT_PROCESSING=true environment variable which skips the wait for processing to complete 😇

---

The reason this was added is because processing on all screenshots need to be complete before the app is submitted.

[changusmc]

Got it, I think in terms of this PR, we're good to go because I was failing in the "remove all previous screenshots" step.

[joshdholtz]

Thanks so much for working with me on these issues! I really appreciate the time you spent helping. I'd give you a 🏆 if I could.

[changusmc]

Absolutely, I'm happy to help!

[changusmc]

After almost 2 hours, the run finished and it errorred for the same reason

DEBUG [11:06:37]: << GET appScreenshots/***: 200 {"data"=>{"type"=>"appScreenshots", "id"=>"***", "attributes"=>{"fileSize"=>1354637, "fileName"=>"0_IMESSAGE_APP_IPAD_PRO_3GEN_129_0.ftl_d6e265d912c9f2e07860f8c52e5a785b_1_ipadPro129_1.0x0ss.jpg", "sourceFileChecksum"=>nil, "imageAsset"=>nil, "assetToken"=>"PurpleSource114/v4/a8/51/58/a851586f-830a-1b14-9635-da951ae23cbf/***_0_IMESSAGE_APP_IPAD_PRO_3GEN_129_0.ftl_d6e265d912c9f2e07860f8c52e5a785b_1_ipadPro129_1.0x0ss.jpg", "assetType"=>"SCREENSHOT", "uploadOperations"=>[{"method"=>"PUT", "url"=>"https://store-037.blobstore.apple.com/itmspod11-assets-massilia-037001/PurpleSource114%2Fv4%2Fa8%2F51%2F58%2Fa851586f-830a-1b14-9635-da951ae23cbf%2FB4qS0z7vNn0_YCzDgaChrPGAqkgOajK75qemTiiN4Bg_U003d-1593626793351?uploadId=98ba5080-bbc5-11ea-bd50-b8599fef42ed&Signature=OljksNuQdg4w4IVMjRhrF713J4o%3D&AWSAccessKeyId=MKIA9HA11I4FU8DC7S5M&partNumber=1&Expires=1594231593", "length"=>1354637, "offset"=>0, "requestHeaders"=>[{"name"=>"Content-Type", "value"=>"image/jpg"}]}], "assetDeliveryState"=>{"errors"=>[{"code"=>"IMAGE_BAD_FILE_EXTENSION", "description"=>"IMAGE_BAD_FILE_EXTENSION"}], "warnings"=>nil, "state"=>"FAILED"}, "uploaded"=>nil}, "relationships"=>{"appScreenshotSet"=>{"links"=>{"self"=>"https://appstoreconnect.apple.com/iris/v1/appScreenshots/***/relationships/appScreenshotSet", "related"=>"https://appstoreconnect.apple.com/iris/v1/appScreenshots/***/appScreenshotSet"}}}, "links"=>{"self"=>"https://appstoreconnect.apple.com/iris/v1/appScreenshots/***"}}, "links"=>{"self"=>"https://appstoreconnect.apple.com/iris/v1/appScreenshots/***"}}

[joshdholtz]

@changusmc What is the full name of the file it was uploading? Was it 0_IMESSAGE_APP_IPAD_PRO_3GEN_129_0.ftl_d6e265d912c9f2e07860f8c52e5a785b_1_ipadPro129_1.0x0ss.jpg?

[changusmc]

@changusmc What is the full name of the file it was uploading? Was it 0_IMESSAGE_APP_IPAD_PRO_3GEN_129_0.ftl_d6e265d912c9f2e07860f8c52e5a785b_1_ipadPro129_1.0x0ss.jpg?

Yup that is correct.. let me try the download_screenshots command again in a clean folder to be sure where it's coming from

[joshdholtz]

@changusmc Yeah yeah, I did clean up the naming of the files that get downloaded so maybe that might help. I'm going to try uploading something with that name to see if I get that same error 🙃

[joshdholtz]

@changusmc I was able to upload something with that same file name so I don't think it was that 😔

[joshdholtz]

Ohhhh, I think a clean folder is what is needed! It was downloading them as PNGs but with the JPG extension. I shouldn't have assumed everything was a PNG at first 🤦

[changusmc]

Yea i downloaded them to a clean folder and it looks like deliver is grabbing the jpgs

[11:27:13]: Downloading existing screenshot '0_IMESSAGE_APP_IPAD_PRO_3GEN_129_0.0x0ss.jpg' for language 'uk'
[11:27:14]: Downloading existing screenshot '1_IMESSAGE_APP_IPAD_PRO_3GEN_129_1.0x0ss (1).jpg' for language 'uk'
[11:27:15]: Downloading existing screenshot '2_IMESSAGE_APP_IPAD_PRO_3GEN_129_2.0x0ss (2).jpg' for language 'uk'
[11:27:15]: Downloading existing screenshot '3_IMESSAGE_APP_IPAD_PRO_3GEN_129_3.0x0ss (3).jpg' for language 'uk'
[11:27:16]: Downloading existing screenshot '4_IMESSAGE_APP_IPAD_PRO_3GEN_129_4.0x0ss (4).jpg' for language 'uk'

What should I do now?

[joshdholtz]

@changusmc That should be good! They are actually jpgs this time. They had jpg extension before but were actually pngs 😇 If you want to try uploading them that would be 💯

[changusmc]

I turned off processing, and it's currently running, 50 minutes and counting.

[joshdholtz]

🤞 😬 🤞

[changusmc]

It worked!

|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | opt_out_usage              | 0           |
| 2    | Verifying fastlane version | 0           |
| 3    | default_platform           | 0           |
| 4    | deliver                    | 4234        |
+------+----------------------------+-------------+

[13:00:33]: fastlane.tools just saved you 71 minutes! 🎉

[joshdholtz]

YESSSSSSSS... Thank you so much again! ❤️

[fastlane-bot]

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀