Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] Fixed crash on running 'deliver download_metadata' #16964

Merged
merged 1 commit into from Jul 29, 2020

Conversation

ha1f
Copy link
Contributor

@ha1f ha1f commented Jul 29, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

If we run fastlane deliver download_metadata with empty content, it crashes and the process will be interrupted.

closes #16949

Description

I use default string for nil.

Testing Steps

@ha1f ha1f changed the title Fixed crash on running 'deliver download_metadata' [deliver] Fixed crash on running 'deliver download_metadata' Jul 29, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks so much for making this fix ❤️ I really appreciate the contribution!

@joshdholtz joshdholtz merged commit 513245a into fastlane:master Jul 29, 2020
@SebaRossi94
Copy link

Hello there, should i update fastlane in order to be able to run fastlane deliver init?
Thanks for the quick fix

@fastlane-bot
Copy link

Hey @ha1f 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.154.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deliver download_metadata: [!] undefined method `+' for nil:NilClass
5 participants