Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] Fixed crash on running 'deliver download_metadata' #16964

Merged
merged 1 commit into from Jul 29, 2020
Merged

[deliver] Fixed crash on running 'deliver download_metadata' #16964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion deliver/lib/deliver/setup.rb
View file
Open in desktop
Expand Up @@ -130,7 +130,7 @@ def generate_metadata_files(app, version, path)
end # errors if doesn't exist
UploadMetadata::REVIEW_INFORMATION_VALUES.each do |file_key, attribute_name|
if app_store_review_detail
content = app_store_review_detail.send(attribute_name)
content = app_store_review_detail.send(attribute_name) || ""
else
content = ""
end
Expand Down