[scan] fix scan regression caused by not setting slack_default_payloads option

[rogerluan]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Resolves #17915
Resolves #17898
This PR fixes a regression introduced in #17866

This PR supersedes #17919 (also please do read the comments there, for extra context!)

Description

By passing nil in scan's slack_default_payloads option (or omitting), then slack action (called down the road within scan) would crashes.
Slack action's default_payloads option is non-null and has a default value. Theoretically, if you pass nil to it, it should pick up the default value and just work.
However, in this very specific scenario, scan was calling the Slack action without invoking the options initializer - it was just passing a raw hash to Slack's runner. Naturally, by not invoking the options initializer, the default values wouldn't be loaded into Slack's options.

So the fix for this issue is just the first commit, where I modify how scan invokes Slack action.

The subsequent commits are meant to improve code by making it more consistent, by swapping Fastlane::ConfigurationHelper.parse with FastlaneCore::Configuration.create. The former was pretty much only used in this file, while the latter is being used in over 300+ occurrences - seems just like the right way to do it 😊

I also cleaned up the test I had written earlier.

NOTE: I'm not too happy with the changes I had to made here 3e80113 - not sure if what we had before is an anti-pattern, or if what I did is an anti-pattern, but neither looks/feels great 😬 I appreciate any and every feedback wrt these specs 🙏

Testing Steps

Demo project, kindly provided by @crazymanish: Demo.zip

Before (as of master):

cd into the demo project, run bundle install, then bundle exec fastlane test. It will crash with undefined method map' for nil:NilClass` error.

Now (in this branch):

To test this branch, modify your demo project's Gemfile as:

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "rogerluan-fix-scan-slack-integration"

And run bundle install to apply the changes.

Now if you run bundle exec fastlane test, it will still fail, but it's because we're providing a fake slack_url 😇
If you test this branch in your own project, it should succeed 👍

cc @crazymanish 🤗

[crazymanish]

Looks good, thank you for the fix. Unit tests too 💪🚀

[stherold]

Looks good for us 👍

[ainame]

Nice fix! I suggested how to test the change otherwise LGTM.

[ainame]

Well done👍

[mathaeus]

@rogerluan thanks for fixing this. Is there an estimated time of when this will be released? :)

[rockshassa]

Can we get this merged ASAP please? With the upcoming Feb deadline for enabling 2FA on apple developer accounts, we need this to be working.

[ainame]

@mathaeus @rockshassa Hi. Sorry for the inconvenience🙇 @joshdholtz is responsible for final checks and release a new version in the core team's flow but he is busy due to a personal circumstances at this moment👶 So please bear with us for a while.

In the meantime, if you really need this change, you can still use this PR's branch in your project. Use below line in your Gemfile. I guess this is the best part of using an OSS project, right? 😛

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "rogerluan-fix-scan-slack-integration"

[joshdholtz]

Will get this merged and released tomorrow! Sorry about that

[mathaeus]

Thanks for the follow up @ainame and @joshdholtz. And congrats @joshdholtz 👶 !!

[rockshassa]

yup, thanks for the quick response @ainame and congrats @joshdholtz ! 🙏

[joshdholtz]

I love this fix! Thank you so much for another awesome contribution ❤️

[fastlane-bot]

Hey @rogerluan 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀