Fix duplicate use_system_scm option in #17832 #17957
Conversation
This will allow usage of `include("foo").once`
1) Scan Scan::TestCommandGenerator uses system scm options exactly once
Failure/Error: expect(result).to include("-scmProvider system").once
expected ["set -o pipefail &&", "env NSUnbufferedIO=YES xcodebuild", "-scheme app", "-project ./scan/examples/...it --output '/var/folders/qz/91qlx7gn30l6rfcwjfzsv_ph0000gn/T/junit_report20210113-97481-17c5v9n' "] to include "-scmProvider system" once but it is included twice
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
plu
changed the title
|
Fixes duplicate option |
| @@ -102,7 +102,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| # Development only | |||
| spec.add_development_dependency('rake') | |||
| spec.add_development_dependency('rspec', '~> 3.9.0') | |||
| spec.add_development_dependency('rspec', '~> 3.10.0') | |||
There was a problem hiding this comment.
Do you actually need this bump in "this PR"? If so can you please clarify that?
There was a problem hiding this comment.
Yes, to get the include(...).once matcher.
|
Thank you for the review! |
|
Hey @plu 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
…cm` option to snapshot (#17832) * Fix gym -showBuildSettings command when providing use_system_scm option. - Also add use_system_scm option to snapshot to fix specs. * Fix duplicate use_system_scm option in #17832 (#17957) * Bump rspec version This will allow usage of `include("foo").once` * Add failing test 1) Scan Scan::TestCommandGenerator uses system scm options exactly once Failure/Error: expect(result).to include("-scmProvider system").once expected ["set -o pipefail &&", "env NSUnbufferedIO=YES xcodebuild", "-scheme app", "-project ./scan/examples/...it --output '/var/folders/qz/91qlx7gn30l6rfcwjfzsv_ph0000gn/T/junit_report20210113-97481-17c5v9n' "] to include "-scmProvider system" once but it is included twice * Deduplicate scmProvider option * Fix build command generator * Remove extra blank line Co-authored-by: Johannes Plunien <johannes@plunien.de>
No description provided.