Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate use_system_scm option in #17832 #17957

Merged
merged 5 commits into from Jan 14, 2021
Merged

Fix duplicate use_system_scm option in #17832 #17957

merged 5 commits into from Jan 14, 2021

Commits on Jan 13, 2021

  1. Bump rspec version 

    This will allow usage of `include("foo").once`
    @plu
    plu committed Jan 13, 2021
    Copy the full SHA
    fd5f0a7 View commit details
    Browse the repository at this point in the history

  2. Add failing test 

          1) Scan Scan::TestCommandGenerator uses system scm options exactly once
         Failure/Error: expect(result).to include("-scmProvider system").once

           expected ["set -o pipefail &&", "env NSUnbufferedIO=YES xcodebuild", "-scheme app", "-project ./scan/examples/...it --output '/var/folders/qz/91qlx7gn30l6rfcwjfzsv_ph0000gn/T/junit_report20210113-97481-17c5v9n' "] to include "-scmProvider system" once but it is included twice
    @plu
    plu committed Jan 13, 2021
    Copy the full SHA
    60bdfa8 View commit details
    Browse the repository at this point in the history

  3. Deduplicate scmProvider option

    @plu
    plu committed Jan 13, 2021
    Copy the full SHA
    1fbf635 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Fix build command generator

    @plu
    plu committed Jan 14, 2021
    Copy the full SHA
    190c6e7 View commit details
    Browse the repository at this point in the history

  2. Remove extra blank line

    @plu
    plu committed Jan 14, 2021
    Copy the full SHA
    364f634 View commit details
    Browse the repository at this point in the history