Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] Adding three missing beta testers/groups methods #19039

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

gsavit
Copy link
Contributor

@gsavit gsavit commented Jul 1, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Implementing the following missing TestFlight endpoints for beta testers/groups related functionality:

Add testers to build
Remove testers from build
Remove groups from build

@google-cla google-cla bot added the cla: yes label Jul 1, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for adding these 😊 Just a few suggestions about the order of method parameters so we can keep things consistent

gsavit and others added 2 commits July 2, 2021 17:28
Co-authored-by: Josh Holtz <josh@rokkincat.com>
Co-authored-by: Josh Holtz <josh@rokkincat.com>
@gsavit
Copy link
Contributor Author

gsavit commented Jul 2, 2021

This is great! Thanks for adding these 😊 Just a few suggestions about the order of method parameters so we can keep things consistent

For sure, thanks for the review Josh! I wasn't too sure what to do with the ordering as it seemed to already vary within the file 😅

@gsavit gsavit requested a review from joshdholtz July 2, 2021 15:33
@kerrmarin-lvmh
Copy link

kerrmarin-lvmh commented Jul 6, 2021

This is awesome! And I believe it's a first step towards fixing #17899 ?

@gsavit
Copy link
Contributor Author

gsavit commented Jul 7, 2021

This is awesome! And I believe it's a first step towards fixing #17899 ?

Thanks! I don't quite think this has anything to do with that other issue, unless I'm missing something? (Incidentally, separately, I've been poking around looking for betaTesterMetrics as well and noticing it's not actually available in ASC API, maybe related to that issue...)

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you so much for this PR. Really appreciate it 🥰

@joshdholtz joshdholtz merged commit c07e08d into fastlane:master Aug 2, 2021
@fastlane-bot
Copy link

Hey @gsavit 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.190.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants