-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] Adding three missing beta testers/groups methods #19039
[spaceship] Adding three missing beta testers/groups methods #19039
Conversation
…rom build, and remove groups from build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for adding these 😊 Just a few suggestions about the order of method parameters so we can keep things consistent
Co-authored-by: Josh Holtz <josh@rokkincat.com>
Co-authored-by: Josh Holtz <josh@rokkincat.com>
For sure, thanks for the review Josh! I wasn't too sure what to do with the ordering as it seemed to already vary within the file 😅 |
This is awesome! And I believe it's a first step towards fixing #17899 ? |
Thanks! I don't quite think this has anything to do with that other issue, unless I'm missing something? (Incidentally, separately, I've been poking around looking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you so much for this PR. Really appreciate it 🥰
Hey @gsavit 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.190.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Implementing the following missing TestFlight endpoints for beta testers/groups related functionality:
Add testers to build
Remove testers from build
Remove groups from build