-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action][push_git_tags] escaping branch tag name in push_git_tags action #19223
Conversation
currently, the tag name won't be escaped with a parathesis
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@thegodland Do you mind accepting the Google CLA so we can merge this? 😇 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you for providing this fix ❤️
Hi. Thank you. I will do that |
@googlebot I signed it! |
Hey @thegodland 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.192.0 🚀 |
currently, the tag name won't be escaped with a parathesis
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This fixes the error when push tags to git when tags contain
(
. also inspired by #13444Description
escape
tag
params inpush_git_tags
action to avoid unnecessary errorsTesting Steps
run
fastlane run push_git_tags(tag: "2.4.0(1)")