Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][push_git_tags] escaping branch tag name in push_git_tags action #19223

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

thegodland
Copy link
Contributor

@thegodland thegodland commented Aug 9, 2021

currently, the tag name won't be escaped with a parathesis

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This fixes the error when push tags to git when tags contain (. also inspired by #13444

Description

escape tag params in push_git_tags action to avoid unnecessary errors

Testing Steps

run fastlane run push_git_tags(tag: "2.4.0(1)")

currently, the tag name won't be escaped with a parathesis
@google-cla
Copy link

google-cla bot commented Aug 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 9, 2021
@joshdholtz
Copy link
Member

@thegodland Do you mind accepting the Google CLA so we can merge this? 😇 Thanks!

@joshdholtz joshdholtz changed the title Escaping branch tag name in push_git_tags action [action][push_git_tags] escaping branch tag name in push_git_tags action Aug 10, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for providing this fix ❤️

@thegodland
Copy link
Contributor Author

@thegodland Do you mind accepting the Google CLA so we can merge this? 😇 Thanks!

Hi. Thank you. I will do that

@thegodland
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 10, 2021
@joshdholtz joshdholtz merged commit e4dfa2d into fastlane:master Aug 10, 2021
@fastlane-bot
Copy link

Hey @thegodland 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.192.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants