Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[match] specify s3 object prefix #20344

Merged
merged 1 commit into from Jun 25, 2022
Merged

[match] specify s3 object prefix #20344

merged 1 commit into from Jun 25, 2022

Conversation

iaia
Copy link
Contributor

@iaia iaia commented Jun 2, 2022 •
edited

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #20345

Description

  • Specify s3_object_prefix

Testing Steps

@google-cla
Copy link

google-cla bot commented Jun 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lucgrabowski
lucgrabowski approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@lucgrabowski lucgrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving nuke :) LGTM 🔥

@iaia iaia mentioned this pull request Jun 7, 2022
Closed
4 tasks
joshdholtz
joshdholtz approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Not sure how this was missed 😅 Thanks for fixing!

@joshdholtz joshdholtz changed the title Specify s3 object prefix [match] specify s3 object prefix Jun 25, 2022
@joshdholtz joshdholtz merged commit 4a8c27e into fastlane:master Jun 25, 2022
crazymanish added a commit that referenced this pull request Jun 26, 2022
@crazymanish
Merge branch 'master' into crazymanish-xcodebuild-destination-param-fix
6ca9e1b 
* master:
  [pilot] added the Pilot::TesterExporter class unit tests (#20394)
  Add device Google Pixel 5 (#20389)
  [action][update_info_plist] improve the plist file-path option validation check (#20356)
  Specify s3 object prefix (#20344)
  [snapshot] Add missing iPod touch to Generated Snapshot Reports (#20337)
  [Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) (#20413)
@fastlane-bot
Copy link

Hey @iaia 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Jun 30, 2022
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

@lucgrabowski lucgrabowski lucgrabowski approved these changes

Assignees
No one assigned
Labels
status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find s3 object with nuke command
4 participants
@iaia @fastlane-bot @joshdholtz @lucgrabowski