[frameit] add Device Google Pixel 5 #20389
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@joshdholtz Hey there! Dunno if this is something you'd want to merge, i just added this to automate screenshots with Pixel 5 and also found an issue with the filename of one of the device frames. |
|
I tested your PR and can confirm it worked for me, thanks a lot! |
joshdholtz
changed the title
* master: [pilot] added the Pilot::TesterExporter class unit tests (#20394) Add device Google Pixel 5 (#20389) [action][update_info_plist] improve the plist file-path option validation check (#20356) Specify s3 object prefix (#20344) [snapshot] Add missing iPod touch to Generated Snapshot Reports (#20337) [Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) (#20413)
|
Hey @denrase 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Adds support for Google Pixel 5 device with correct resolution and with colors
Just BlackandSorta Sage.Description
Related: fastlane/frameit-frames#27
Also added the color
Sorta Sage, but there is an issue where the file is not found, as there is a wrong character in the filename. See below:When changing the filename to a regular whitespace, everything works as expected. This should be fixed in
https://github.com/fastlane/frameit-framesTesting Steps
To test this branch, modify your Gemfile as:
gem "fastlane", :git => "https://github.com/denrase/fastlane.git", :branch => "denrase-support-pixel-5"
And run bundle install to apply the changes.