Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interactive console for users as well #21800

Closed
wants to merge 1 commit into from

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Jan 12, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Sometimes I wish to send code for users to test directly into their setup. This would allow to do it.

Description

I've used the similar code in our u3d project here for years https://github.com/DragonBox/u3d/blob/8c156f401f2b8443936e3873b8566a965c783165/lib/u3d/commands.rb#L68-L80

Testing Steps

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should name this command repl instead. Because pedantically speaking the term console does not imply interactivity but more reading output (think macOS's Console.app), while things like pry and irb are called REPL (Read-Execute-Print Loop).

That being said since you added bin/console with such a name too we should keep the names consistent.

@lacostej
Copy link
Collaborator Author

I'm wondering if we should name this command repl instead. Because pedantically speaking the term console does not imply interactivity but more reading output (think macOS's Console.app), while things like pry and irb are called REPL (Read-Execute-Print Loop).

That being said since you added bin/console with such a name too we should keep the names consistent.

I wouldn't change bin/console as it follows the bundler convention. Console there probably refer to the original system consoles. The consistency is I think also a strong argument to keep the command identical.

Note that Mac's Console is probably one of the few IT system named console that doesn't do input. I'll blame Apple for the confusion.

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟 this is awesome and quite intuitive IMO.

I think this deserves to be documented somewhere, for discoverability! Idk where exactly, though. It might be in this repo, or in https://github.com/fastlane/docs, what do you think? Where should this live?

@lacostej
Copy link
Collaborator Author

Nice! 🌟 this is awesome and quite intuitive IMO.

I think this deserves to be documented somewhere, for discoverability! Idk where exactly, though. It might be in this repo, or in https://github.com/fastlane/docs, what do you think? Where should this live?

yes, in this repo and in the docs would be nice, together with a nice screenshot or even an animated gif.

Example:

image

I hope to use it to help troubleshoot issues like #21765 :)

@lacostej lacostej deleted the branch fastlane:feature/console January 13, 2024 17:01
@lacostej lacostej closed this Jan 13, 2024
@rogerluan
Copy link
Member

@lacostej you probably need to reopen this manually 👀

@lacostej
Copy link
Collaborator Author

yes, but I don't seem to be able in the same PR. Something went wrong.

@lacostej
Copy link
Collaborator Author

now it lets me

@lacostej
Copy link
Collaborator Author

nope, it is stuck. I'll reopen a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants