-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an interactive console for users as well #21800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should name this command repl
instead. Because pedantically speaking the term console does not imply interactivity but more reading output (think macOS's Console.app), while things like pry
and irb
are called REPL (Read-Execute-Print Loop).
That being said since you added bin/console
with such a name too we should keep the names consistent.
I wouldn't change Note that Mac's Console is probably one of the few IT system named console that doesn't do input. I'll blame Apple for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🌟 this is awesome and quite intuitive IMO.
I think this deserves to be documented somewhere, for discoverability! Idk where exactly, though. It might be in this repo, or in https://github.com/fastlane/docs, what do you think? Where should this live?
yes, in this repo and in the docs would be nice, together with a nice screenshot or even an animated gif. Example: I hope to use it to help troubleshoot issues like #21765 :) |
@lacostej you probably need to reopen this manually 👀 |
yes, but I don't seem to be able in the same PR. Something went wrong. |
now it lets me |
nope, it is stuck. I'll reopen a new one. |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Sometimes I wish to send code for users to test directly into their setup. This would allow to do it.
Description
I've used the similar code in our u3d project here for years https://github.com/DragonBox/u3d/blob/8c156f401f2b8443936e3873b8566a965c783165/lib/u3d/commands.rb#L68-L80
Testing Steps