Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xros as supported platform everywhere appletvos appears #21864

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add xros as supported platform everywhere appletvos appears #21864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a1ddb
Add xros as valid option to deliver
demonnic Feb 11, 2024
8bfbcdf
Add xros to list of valid options in actions
demonnic Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deliver/lib/deliver/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def self.available_options
optional: true,
default_value: "ios",
verify_block: proc do |value|
UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value)
UI.user_error!("The platform can only be ios, appletvos, osx, or xros") unless %('ios', 'appletvos', 'osx', 'xros').include?(value)
end),

# live version
Expand Down
4 changes: 2 additions & 2 deletions deliver/lib/deliver/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def verify_binary
transporter = transporter_for_selected_team

case platform
when "ios", "appletvos"
when "ios", "appletvos", "xros"
package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
app_id: Deliver.cache[:app].id,
ipa_path: ipa_path,
Expand Down Expand Up @@ -209,7 +209,7 @@ def upload_binary
transporter = transporter_for_selected_team

case platform
when "ios", "appletvos"
when "ios", "appletvos", "xros"
package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
app_id: Deliver.cache[:app].id,
ipa_path: ipa_path,
Expand Down
2 changes: 1 addition & 1 deletion fastlane/lib/fastlane/actions/app_store_build_number.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def self.available_options
optional: true,
default_value: "ios",
verify_block: proc do |value|
UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value)
UI.user_error!("The platform can only be ios, appletvos, osx, or xros") unless %('ios', 'appletvos', 'osx', 'xros').include?(value)
end),
FastlaneCore::ConfigItem.new(key: :team_name,
short_option: "-e",
Expand Down
1 change: 1 addition & 0 deletions fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ The available options:
- 'ios'
- 'appletvos'
- 'osx'
- 'xros'


### Non-Localized
Expand Down
4 changes: 2 additions & 2 deletions fastlane/lib/fastlane/actions/download_dsyms.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :platform,
short_option: "-p",
env_name: "DOWNLOAD_DSYMS_PLATFORM",
description: "The app platform for dSYMs you wish to download (ios, appletvos)",
description: "The app platform for dSYMs you wish to download (ios, appletvos, xros)",
default_value: :ios),
FastlaneCore::ConfigItem.new(key: :version,
short_option: "-v",
Expand Down Expand Up @@ -351,7 +351,7 @@ def self.authors
end

def self.is_supported?(platform)
[:ios, :appletvos].include?(platform)
[:ios, :appletvos, :xros].include?(platform)
end

def self.example_code
Expand Down
2 changes: 1 addition & 1 deletion fastlane/lib/fastlane/actions/latest_testflight_build_number.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def self.available_options
optional: true,
default_value: "ios",
verify_block: proc do |value|
UI.user_error!("The platform can only be ios, osx, or appletvos") unless %('osx', ios', 'appletvos').include?(value)
UI.user_error!("The platform can only be ios, osx, xros, or appletvos") unless %('osx', ios', 'appletvos', 'xros').include?(value)
end),
FastlaneCore::ConfigItem.new(key: :initial_build_number,
env_name: "INITIAL_BUILD_NUMBER",
Expand Down
6 changes: 3 additions & 3 deletions fastlane/lib/fastlane/actions/set_changelog.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ def self.available_options
end),
FastlaneCore::ConfigItem.new(key: :platform,
env_name: "FL_SET_CHANGELOG_PLATFORM",
description: "The platform of the app (ios, appletvos, mac)",
description: "The platform of the app (ios, appletvos, mac, xros)",
default_value: "ios",
verify_block: proc do |value|
available = ['ios', 'appletvos', 'mac']
available = ['ios', 'appletvos', 'mac', 'xros']
UI.user_error!("Invalid platform '#{value}', must be #{available.join(', ')}") unless available.include?(value)
end)
]
Expand All @@ -183,7 +183,7 @@ def self.authors
end

def self.is_supported?(platform)
[:ios, :appletvos, :mac].include?(platform)
[:ios, :appletvos, :mac, :xros].include?(platform)
end

def self.example_code
Expand Down
6 changes: 3 additions & 3 deletions fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,10 @@ def self.available_options
end),
FastlaneCore::ConfigItem.new(key: :platform,
env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_PLATFORM",
description: "The platform of the app (ios, appletvos, mac)",
description: "The platform of the app (ios, appletvos, mac, xros)",
default_value: "ios",
verify_block: proc do |value|
available = ['ios', 'appletvos', 'mac']
available = ['ios', 'appletvos', 'mac', 'xros']
UI.user_error!("Invalid platform '#{value}', must be #{available.join(', ')}") unless available.include?(value)
end),
FastlaneCore::ConfigItem.new(key: :dsym_worker_threads,
Expand Down Expand Up @@ -216,7 +216,7 @@ def self.authors
end

def self.is_supported?(platform)
[:ios, :appletvos].include?(platform)
[:ios, :appletvos, :xros].include?(platform)
end

def self.example_code
Expand Down