Implements workaround for generic archive bug. #4118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
|
|
Generated by 🚫 danger |
| @@ -3,6 +3,9 @@ class Manager | |||
| def work(options) | |||
| Gym.config = options | |||
|
|
|||
| puts ":I" | |||
| exit | |||
There was a problem hiding this comment.
Looks like debug code that snuck in? ;)
|
@mfurtak All up to date, let me know if you are happy and then before we merge I'll confirm that this still works in real-life :) |
|
This looks good to me! If you can give it your final checks and then squash the commits, we'll get it in 👍 |
|
Should be good to go :) - just ran it and it works. |
|
@KrauseFx Just dange not liking the squash |
|
Merged as #4325 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for CocoaPods/CocoaPods#4178
In certain project configurations Xcodebuild creates a generic archive with the iOS App with Apple Watch App and the Apple Watch app in the products folder.
This is a small tweak to remove any Watch IPAs in the root of the archive (i.e not inside of a iOS App) since in pretty much all cases a developer wouldn't want / need this.
Hopefully this will increase the chances that gym will pick the correct IPA file when this bug occurs.