Implement workaround for generic archive bug. #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfurtak
changed the title
mfurtak
force-pushed
the
generic-archives-bug
branch
from
28be20c
to
c5edb1c
Compare
Generated by 🚫 danger |
|
@jcampbell05 Can you give this a quick once-over to make sure that it still looks good after the recreation? 👍 |
| @@ -16,6 +16,7 @@ def run | |||
| FileUtils.mkdir_p(Gym.config[:output_directory]) | |||
|
|
|||
| if Gym.project.ios? || Gym.project.tvos? | |||
| fix_archive | |||
There was a problem hiding this comment.
it may be nice to use a more precise method name.
mfurtak
force-pushed
the
generic-archives-bug
branch
from
c7f5492
to
0e5fe4f
Compare
|
Ready to go from my side pending 👍 from @jcampbell05 and @lacostej |
|
Looks good to me :) thanks for all your help on this @mfurtak :) |
|
Fine for me ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for CocoaPods/CocoaPods#4178
In certain project configurations Xcodebuild creates a generic archive with the iOS App with Apple Watch App and the Apple Watch app in the products folder.
This is a small tweak to remove any Watch IPAs in the root of the archive (i.e not inside of a iOS App) since in pretty much all cases a developer wouldn't want / need this.
Hopefully this will increase the chances that gym will pick the correct IPA file when this bug occurs.