-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testfairy action] enable parameters/options #4818
Conversation
type: Array, | ||
env_name: "FL_TESTFAIRY_METRICS", | ||
description: "Array of metrics to record (cpu,memory,network,phone-signal,gps,battery,mic,wifi)", | ||
default_value: [ :cpu, :memory, :network, :wifi ]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space inside square brackets detected.
Generated by 🚫 danger |
description: "Symbols mapping file", | ||
default_value: Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH], | ||
verify_block: proc do |value| | ||
UI.user_error!("Couldn't find ipa file at path '#{value}'") unless File.exist?(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message here say ipa file
but that should be .dSYM file right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch indeed. That's a c&p error. Let me fix that.
FastlaneCore::ConfigItem.new(key: :options, | ||
type: Array, | ||
env_name: "FL_TESTFAIRY_OPTIONS", | ||
description: "Array of options (shake,video-only-wifi,anonymous)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a known set of acceptable options that could be validated against here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3 listed in the docs at the moment.
My concern from the metrics applies here as well though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above regarding error messages returned by the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh - seems like there is no API level validation for these options.
Please let me know what needs to be changed to get this merged. |
FastlaneCore::ConfigItem.new(key: :icon_watermark, | ||
env_name: "FL_TESTFAIRY_ICON_WATERMARK", | ||
description: "Add a small watermark to app icon", | ||
default_value: 'on'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From http://docs.testfairy.com/API/Upload_API.html, the default value of icon_watermark
is 'off'. Is there a reason for the change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I was trying that out it might have slipped in that way. I guess it's a useful thing to have - but changing that to the API default probably makes sense.
@@ -87,7 +181,7 @@ def self.output | |||
end | |||
|
|||
def self.authors | |||
["taka0125"] | |||
["taka0125","tcurdt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space missing after comma.
@asfalcone I've added the validation |
|
||
client_options = Hash[params.values.map do |key, value| | ||
case key | ||
when :api_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can all of the symbol keys cases be collapsed into a single statement?
when :api_key, :ipa, ...
[key, value]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now they have the same order as the configuration items. So it's easier not to miss any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...but if you want - that's an easy change.
@tcurdt Thanks for all of your effort! This is great! 🚀 |
This was released in |
commit a26bb70ef775bc9f3bbe9b2d0fe656a8ebbb739c Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 15:06:28 2016 -0700 Renamed header (#5219) commit 983d1d1620c2237bdfda194ec885a4efa3d8ed0e Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 12:42:37 2016 -0700 Test coverage reports were not reliable (#5218) * Test coverage reports were not reliable * Fixed tests commit 9278dce98eb5ebc099310142c0697c841fe64a6f Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 11:31:54 2016 -0700 [gym] Deprecated provisioning_profile_path (#5106) * [gym] Deprecated provisioning_profile_path * Removed duplicate deprecated output commit 3863609eb6b27fd03ff3b3c282522268dc81c3e7 Author: Logan Gauthier <logan.paul.gauthier@gmail.com> Date: Fri Jun 24 13:27:14 2016 -0500 Fix incorrect docs for last_git_commit_message (#5212) `last_git_commit_message` returns a string that's just the message from the commit. The example was showing that it returned a hash representing the commit as a whole. commit cfb470d133b8fcf0aae28b97ecc82b443c005410 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 11:24:50 2016 -0700 [fastlane_core] Added missing prefix when printing out GH issue errors (#5215) commit 3d774de27df6420e76e49ba44b71af5997b55eb9 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 11:24:07 2016 -0700 Added .DS_STORE to .gitignore (#5177) commit 2afd9f83b9a9982233b9314d675cc2fdf95aa3fa Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 24 11:18:48 2016 -0700 Added 'krausefx-shenzhen' gem to list of RubyGems (#5099) commit 5d1bdbfa013cc5d3420b453b70cc80853d6b63d4 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 24 13:27:40 2016 -0400 version bump (#5210) commit 6e857db043c374f2c3f13a6cce0781aa59db5a25 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 24 13:05:20 2016 -0400 remove danger from build steps (#5214) commit ac1cea530ca02631628d29a155e43b1ab275fcee Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 24 11:48:46 2016 -0400 Crashlytics Beta Initialization * start to crash beta * add check for is_ios * update feature description commit 424e8137c3438474b5290880a0cfc2d89259c169 Author: Evan Grim <evan@mirgnave.com> Date: Thu Jun 23 17:32:22 2016 -0500 Fix missing close paren in README.md (#5204) commit 62f202f4a5afd006de8532ba06676c7744734bd9 Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 23 15:38:20 2016 -0400 bump version (#5202) commit d1ff64e2864e507bee679e85604ea671a17af5b1 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 22 16:20:23 2016 -0700 [fastlane_core] Updated gh_inspector dependency (#5197) commit b3457a746bf3fccc6ff10f6df57951d5976cf5a1 Author: Julian Nadeau <julian@jnadeau.ca> Date: Wed Jun 22 17:15:10 2016 -0400 Dont generate empty platform docs when there are no lanes (#5196) commit 4798e9c07086bc4bd806acee3980fd260708bf30 Author: David Ohayon <ohayon.1@gmail.com> Date: Tue Jun 21 14:54:25 2016 -0400 add feature manager and refactor itms transporter (#5097) commit 4ef273975d2f39dc985f591dd2c134cae67fc2f5 Merge: f052268 a8bf92a Author: Hemal Shah <hjshah25@gmail.com> Date: Tue Jun 21 13:13:26 2016 -0400 Merge pull request #5181 from fastlane/modified_READMEs Modified READMEs to provide clarity on what the different tools do commit a8bf92a11a284a11d3dd14cfda070b6e25a0f0cb Author: Hemal Shah <hjshah25@gmail.com> Date: Tue Jun 21 09:58:22 2016 -0400 Modified READMEs to provide clarity on what the tools do commit f052268c50660e91da728c6c55e807d26df070e4 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 20 13:06:16 2016 -0700 [fastlane] Updated fastlane_core dependency (#5172) commit fe7f576e7737e1fc96975dccfb3ad346231dd107 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 20 11:21:17 2016 -0700 [Ready] Added initial GitHub issue search feature (#5162) * Added initial GitHub issue search feature Thanks @orta Depends on https://github.com/orta/gh-issues-inspector/pull/7 * Migrated issue search to new gem name cc @orta * We don't want GitHub search to cause a crash after a crash * Updated gh_inspector dependency to 1.0 commit 057343a11f6212c72912b9da5f232fc4a5c1de50 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 20 11:20:56 2016 -0700 [fastlane_core] Version bump (#5171) Added inline showing of relevant GitHub issue when fastlane fails commit de2c22dbb9e971513d88b5ccf553395bb6bab723 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 20 09:45:27 2016 -0700 Added ` around frameit in frameit README (#5167) commit 85d0ef56f614993631b9e3edf73dadb9be880c83 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 20 09:34:02 2016 -0700 Use user_error! instead of raise for snapshot failure (#5146) commit b3ead5ff944321899899d11b75f2361d34e06ee2 Author: Travis Collins <traviscollins@users.noreply.github.com> Date: Sun Jun 19 23:36:19 2016 -0400 Updated frameit Readme (#5166) * Updated frameit Readme Added an important not about backgrounds not being optional then titles are desired. * Updated frameit readme per request commit 551b0eea99171caf1190c9f536d814aa75c1ccba Author: Mark O'Keeffe <senshi001@gmail.com> Date: Sun Jun 19 06:57:10 2016 +1000 Proper escaping of codesigning identity (#5148) Related to #5089 If a codesigning identity contains apostrophes, the build will fail. commit b5ab73a3782f5e2253978dd654b64a7ed4c7d34f Author: Boris Bügling <neonichu2@gmail.com> Date: Fri Jun 10 16:52:38 2016 -0700 Merge test results and send to coveralls (#5091) commit c56039e823ce88c8a0cf51025c02bde7402fe906 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 10 09:47:48 2016 -0700 [fastlane] Version bump (#5084) * Added error handling when dSYM download failed * Added update checker for plugins (#5039) * Generate empty JSON if there is no `Fastfile` (#5056) * Updated fastlane.gemspec to include fastlane team (#5026) * Updating `upload_symbols_to_sentry` action to allow for bearer auth (#4884) * Changed Helper.is_ci? to UI.interactive? (#5037) * [fastlane] Show error message when plugin name has _ in the name when adding a plugin (#5034) * Reduce gem size by 70% by excluding device grid assets from .gem (#5024) * Improved error handling for `download_dsyms` action * Fixed `fastlane action` table design for legacy actions (#5052) commit 1cc745461fd6d8a8fbae8f35ba5cfad072574ae7 Author: Andrea Falcone <andrea@crashlytics.com> Date: Fri Jun 10 10:48:11 2016 -0400 Update fastlane dependency on spaceship (#5096) commit 817d036933c2d01fbd2dc86be5602ee8ce0acf97 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 10 07:45:52 2016 -0700 Removed dot in main readme (#5081) commit fb4ca79b6b61b2e3dacb2c9c6e4f607f4d6bb2b6 Merge: a7a2b02 292fdfb Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri Jun 10 10:43:56 2016 -0400 Merge pull request #5088 from markokeeffe/patch-1 Escape code signing identity commit a7a2b02cd1533af8a9b6b11412004b12743bfb4b Author: Andrea Falcone <andrea@crashlytics.com> Date: Fri Jun 10 10:42:06 2016 -0400 Fix tests that are failing due to shellescape changes (#5095) commit 5d90dc0f2534c0ce7eb3209a00876648214ae8be Author: Boris Bügling <neonichu2@gmail.com> Date: Thu Jun 9 22:18:08 2016 -0700 Add `danger-device_grid` to gems in `Rakefile` (#5087) * Add `danger-device_grid` to gems in `Rakefile` * Add rspec things commit 292fdfbb16f1df60e635a10fe15df3c942a2e421 Author: Mark O'Keeffe <senshi001@gmail.com> Date: Fri Jun 10 15:00:40 2016 +1000 Escape code signing identity Attempting to build gym with a --codesigning_identity value that has an apostrophe (e.g. `gym --scheme "My App" --codesigning_identity "iPhone Distribution: Mark's Company (ABCDE123456)"`) will fail with the error: ```bash sh: -c: line 0: syntax error near unexpected token `(' ``` Escaping the value instead of quoting fixes the problem. commit f742a5c0f097ce00c03445e3a573eca833f9910a Author: Boris Bügling <neonichu2@gmail.com> Date: Thu Jun 9 20:42:57 2016 -0700 Migrate `device_grid` plugin to new danger API (#5060) * Migrate `device_grid` plugin to new danger API * Add missing `require` * Do not use Bundler anymore * Make hound happy and move spec to new gem * Update `device_grid` README * Remove `device_grid` spec from `fastlane` It has been moved over to the separate `device_grid` gem. * Rename directory to `danger-device_grid` commit 1cac2ccd9c5f377fa028d83e5237917474022f36 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 9 19:14:55 2016 -0700 Added error handling when dSYM download failed (#5082) Fixes https://github.com/fastlane/fastlane/issues/5044 commit 59636589f457c12e8ea133264d25724ac92bfc08 Author: Max Chuquimia <max@chuquimianproductions.com> Date: Fri Jun 10 11:00:53 2016 +1000 UI.user_error when resign failures with non-zero exit code (#5059) commit 0d5f5220a857090f8f966b2cad6119dc20b1a997 Author: David Cordero <dcorderoramirez@gmail.com> Date: Fri Jun 10 01:51:14 2016 +0200 push_to_git_remote: Add optional parameter 'tags' to avoid pushing tags (#5080) * Add tags parameter to the tests * Include, optionally, the parameter --tags to the git command * Update documentation of the action push_to_git_remote to describe the new parameter 'tags' * Replace tab by spaces to make Hound happier * Replace tab by spaces to make Hound happier commit 71c6d150a61be80be538a3da14c032756ff29e37 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 9 15:28:58 2016 -0700 [spaceship] Version bump (#5074) * Print proper error message when new 2step is used (#4959) * Fix broken urls in Spaceship docs (#4952) * [spaceship] Add .jpeg to the set of recognized media extensions * Sort team selections (#4794) * Removed link to RubyDoc (#4705) * [spaceship] Updated spaceship gem description (#4684) * [spaceship] Add link to GitHub issue for Accept-Encoding fix commit d5f9a9c8d2e1ad483cae4cd90e318831f368eca7 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 9 11:04:52 2016 -0700 [fastlane_core] Version bump (#5072) commit b07b5e6e193fb9a09759a9ef599b11f68e7235e2 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 9 10:12:57 2016 -0700 [gym] Version bump (#5067) * plural agreement typo (#5041) * Improved code style * add support for rbenv in wrap_xcodebuild/xcbuild-safe.sh (#4625) * Enabled fastlane plugins for all the tools (#4941) * [gym] Print out legacy information every time you run gym (#4890) * Fix gym with path with spaces (#4721) * Fix URL (#4604) commit 6a004dae6356faac7e5215003a73864845ef5cb6 Author: Boris Bügling <neonichu2@gmail.com> Date: Wed Jun 8 22:32:39 2016 -0700 Generate empty JSON if there is no `Fastfile` (#5056) The `--json` option should not prompt the user to setup a `Fastfile`. commit 276a2de2241a7a819510ad5982ede1d39ac107d8 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 8 14:41:47 2016 -0700 Added update checker for plugins (#5039) * Added update checker for plugins * Addressed PR feedback commit 6838c1555af6c77b3f90a3b166f5214383cbaaff Author: jerome-mare <jerome.mare@gfi.fr> Date: Wed Jun 8 23:41:32 2016 +0200 Fix jenkins is_ci helper #1340 (#5053) * Fix #1340 adding JENKINS_HOME to test jenkins_ci execution * Fix #1340 adding unit test commit 79a0f93a979641043008a8847eaff81a84e43571 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 8 11:31:29 2016 -0700 Updated fastlane.gemspec to include fastlane team (#5026) commit e1b8d650d39db0006fcded4edba1d7f82ec52abe Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 8 11:31:25 2016 -0700 Fixed `fastlane action` table design for legacy actions (#5052) Actions that don't use ConfigItems didn't show enough columns (missing the new default value column) commit fc18717a60187351ac60338e06a0c3c9b0debd68 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 8 10:46:43 2016 -0700 Added comment on why we need word_wrap (#5040) commit 2862c76cde2579c0d97ebabb93cd3f41d1d2618f Author: David Ohayon <ohayon.1@gmail.com> Date: Wed Jun 8 13:14:14 2016 -0400 Add build setting to xcodebuild command so projects can detect snapshot during build (#5051) Runtime detection is provided by the launch_argument in the helper. commit 2ef7383180958504ad4e1544622f4b64147088d2 Author: Josh Holtz <josh@rokkincat.com> Date: Wed Jun 8 12:01:07 2016 -0500 Updating upload_symbols_to_sentry action to allow for bearer authenti… (#4884) * Updating upload_symbols_to_sentry action to allow for bearer authentication token * Code cleanup and showing warning to recommend the sentry plugin * Added a comment about warning * Removed another line of doc * Fixed some syntax for hound * More rubocop fixes commit 070b4de1805fc84e384205bab68b29936d3c60b1 Author: Gant Laborde <gantman@gmail.com> Date: Wed Jun 8 10:27:26 2016 -0500 plural agreement typo (#5041) commit e6b1c82cc54fd05bbd50c42da21b1840de5ebe88 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue Jun 7 18:42:07 2016 -0700 Changed Helper.is_ci? to UI.interactive? (#5037) commit f51db9e50949dd0b15594eaaab69378deb8bf0ca Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue Jun 7 11:46:49 2016 -0700 [fastlane] Show error message when plugin name has _ in the name when adding a plugin (#5034) commit 4785898be15ba5d0897651cb3250e72a37305f6d Author: David Ohayon <ohayon.1@gmail.com> Date: Tue Jun 7 11:22:31 2016 -0400 Use double quotes around options for xcrun commands (#5032) commit abb5cdfe65f02884364440bd89cdd5f6e97a3722 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 6 17:34:48 2016 -0700 Reduce gem size by 70% by excluding device grid assets from .gem (#5024) commit 1936a4259e5b0d4694c2a8d1f0c04eb1c16df0e7 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 6 13:01:21 2016 -0700 [fastlane] Version bump (#5018) * Fixed OneOff actions not loading the built-in fastlane actions (#5015) * Add CI configurations to plugin template (#5011) * Updated rubocop code style rules * Log SSH output as it is received (#4662) commit 7477b7551e8bdf0eb1146603d675aee6477c3697 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon Jun 6 12:45:07 2016 -0700 Fixed OneOff actions not loading the built-in fastlane actions (#5015) * Fixed OneOff actions not loading the built-in fastlane actions * Fixes https://github.com/fastlane/fastlane/pull/5015/files#r65930337 commit 568edf3fcbc785721be0342416fa4ea5353dcbf8 Author: Boris Bügling <neonichu2@gmail.com> Date: Mon Jun 6 09:49:19 2016 -0700 Add CI configurations to plugin template (#5011) - Add configuration for Circle CI - Add configuration for Travis CI - Ignore 'vendor/*' from Rubocop to avoid CI issues commit bb3da93ae1bda6e2ab0f3b6a1be7fd73b3ca8127 Merge: 4f075e3 4782734 Author: Michael Furtak <michael.furtak@gmail.com> Date: Mon Jun 6 09:57:35 2016 -0400 Merge pull request #5009 from fastlane/code-style Improved code style commit 4782734d4d674e3356fb69bee09ea80f5e395ee7 Author: KrauseFx <KrauseFx@gmail.com> Date: Sun Jun 5 00:10:49 2016 -0700 Improved code style commit 4f075e38fb2b1a09482ba5f205554c17f6427ca4 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Sat Jun 4 22:24:45 2016 -0700 [fastlane] Updated list of plugins (#5008) commit d2004e0a0b9f8a99672dc266d4c73ab92293b7d8 Author: Riley Avron <nerylix@me.com> Date: Fri Jun 3 18:13:36 2016 -0700 Log SSH output as it is received (#4662) * Clean up SSH script Fixes #4504. * Default log to true in ssh_exec * Fix surrounding space on default assignment commit 806d33cde0b8a415b2d464f4fdd470c10e3e5eb7 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 3 17:05:18 2016 -0700 [fastlane] Updated dependencies (#5003) commit 29689c6a722af6a985c918215a027c5fd70f93ac Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 3 17:05:06 2016 -0700 [fastlane] Version bump (#5002) * Improved fastlane plugin template * Add `rubocop` to plugin template (#4951) * Improved plugin default README (#4995) * Add documentation about `itc_provider` option for deliver and pilot * [Scan] Added option to generate the json compilation database with clang naming conventions * Install latest release for an Xcode plugin (#4911) * Improved the docs for hockey action (#4984) * Fix `changelog_from_git_commits` action for CLI * Updated `cocoapods` action to correctly update repo when using `cocoapods` 1.0 * Updated internal dependencies commit 6d9bbecd09031c4741271a45d3368c1b47048696 Author: Boris Bügling <neonichu2@gmail.com> Date: Fri Jun 3 16:54:13 2016 -0700 Fix for missing dotfiles in new plugins (#5004) This happened only when using the packaged gem, because `Dir.glob` does not include dotfiles by default. Using `FNM_DOTMATCH` changes that behaviour. I didn't add a test for this, because the error doesn't surface when developing the gem. commit 4e5b3a003c6907c474a972f7fc0bf350be2dc690 Merge: 317f332 fc88f62 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 3 18:56:25 2016 -0400 Merge pull request #4999 from fastlane/env-var-refactor Fix issue where user could get stuck in a loop of password prompts commit 317f33217c1fb00674e6004227c2aee34cd52ea4 Merge: d823e2c f915fe1 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 3 18:54:36 2016 -0400 Merge pull request #4697 from dtorres/improved_edit_plist Added option to specify scheme in update_info_plist commit d823e2c9fadb2ccf118894cccec599834de360e1 Author: Boris Bügling <neonichu2@gmail.com> Date: Fri Jun 3 13:38:56 2016 -0700 Add `rubocop` to plugin template (#4951) - Copies shared `.rubocop.yml` - Add `rake` and `rubocop` as development dependencies - Add `rspec` and `rubocop` rake tasks - Fix rubocop issues in the template - Tests commit bbb3cab34510d08adb7df7150d4d53de0f9d7a98 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 3 11:40:24 2016 -0700 Improved plugin default README (#4995) * Improved plugin default README * Updated spelling commit fc88f625903e4efee048c4707b84649901924508 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 3 14:26:35 2016 -0400 derp commit aaf5729c664cca48a2fb12f1fb9f1db99d14f882 Merge: 9e79ec9 66ac350 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri Jun 3 14:25:15 2016 -0400 Merge pull request #5000 from fastlane/itc-provider-docs Add documentation about itc_provider option for deliver and pilot commit 66ac350f8beb2ba80451c917343096f82efb6dbb Author: Michael Furtak <mfurtak@twitter.com> Date: Fri Jun 3 14:15:30 2016 -0400 Add documentation about itc_provider option for deliver and pilot commit 00badc13f726d90bb83fc493bf01517b062d5bf5 Author: David Ohayon <ohayon.1@gmail.com> Date: Fri Jun 3 13:55:27 2016 -0400 Fix issue where user could get stuck in a loop of password prompts commit 9e79ec962b70ba00e081e1c48b8295fa9026d624 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri Jun 3 10:32:32 2016 -0700 [fastlane] Removed now: true from appium_spec (#4996) commit 897441e96e79bb2ef75e28e143b2a544bfbb1602 Merge: b94bd13 27b9a5b Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri Jun 3 13:32:02 2016 -0400 Merge pull request #4997 from fastlane/mfurtak-patch-1 Version bump commit 27b9a5b4af38002129feed88fa24edc7609b9b22 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri Jun 3 13:09:05 2016 -0400 [scan] Version bump Changes since release 0.7.1: * Continuing work on #4841 * Scan: Added option to generate the json compilation database with clang naming conventions * Enabled fastlane plugins for all the tools (#4941) commit b94bd137911942231b6c24ae1dad9e0278651d06 Merge: f17ab07 54a07c8 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri Jun 3 12:34:24 2016 -0400 Merge pull request #4992 from fastlane/scan-oclint-integration Scan oclint integration commit 54a07c83fa15e85bc8e770e225730d32b3ed507f Author: Michael Furtak <mfurtak@twitter.com> Date: Thu Jun 2 16:54:52 2016 -0400 Continuing work on #4841 commit 07ac4a47ba16f007384fda00728f8516ba691914 Author: Andy Best <Andy.Best@tribalworldwide.co.uk> Date: Tue May 24 18:16:40 2016 +0100 Scan: Added option to generate the json compilation database with clang naming conventions commit f17ab074c67b9716bf5b26382cfc994516b2e108 Author: Eduard Panasiuk <ed.belarus@gmail.com> Date: Fri Jun 3 15:29:45 2016 +0300 Added ability to use certificate SHA-1 in `sigh` resign (#4898) commit f915fe159bf652cf429496118785627cb586f6bd Author: Diego Torres <warorface@gmail.com> Date: Tue May 17 17:04:41 2016 +0200 Added option to specify scheme in update_info_plist instead of plist_path Added tests for scheme option in update_info_plist Updated to use Xcodeproj::Plist instead commit 14e56301de51d6431a749a302a400c3026910461 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 2 16:55:35 2016 -0700 [danger] Added detection of # in PR-body (#4985) commit 948397fd4862d7ce34e72b8315ea76114a915904 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 2 16:40:37 2016 -0700 [pilot] Version bump (#4987) - Stop skipping first line of csv in pilot import commit d86a4825751856c9e0ac154bb4431a7ebbff9d7f Author: Boris Bügling <neonichu2@gmail.com> Date: Thu Jun 2 16:05:16 2016 -0700 Install latest release for an Xcode plugin (#4911) * Install latest release for an Xcode plugin Using the `github` option instead of `url`, fastlane can now determine the URL for the latest version of a plugin automatically. * Better error handling and minor fixes - Handles non-existent releases and other GH errors - Make `:github` option optional - Fix formatting and use fake URL for `url` in `Actions.md` commit 6e1c350addcdcd348240d112355b5b15d0126032 Author: Neer Friedman <neerfri@gmail.com> Date: Fri Jun 3 00:58:44 2016 +0200 add support for rbenv in wrap_xcodebuild/xcbuild-safe.sh (#4625) commit c5ac2846e54faaf697eba39c88ae532a2755d9f0 Author: Peter Ryszkiewicz <pryszkie@gmail.com> Date: Thu Jun 2 17:45:58 2016 -0500 Improved the accuracy of the hockey description. (#4984) commit 00ae0133d742daae63efb20ccc351cf79eb198d8 Merge: bc9155c 5d0f405 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:59:09 2016 -0400 Merge pull request #4977 from fastlane/mfurtak-patch-1 Version bump commit bc9155c48cb79d83ff363a5388061c659a2a2806 Merge: bf85387 cd0c8e4 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:57:44 2016 -0400 Merge pull request #4978 from fastlane/mfurtak-patch-2 Version bump commit cd0c8e4dea0cfc2bf2af19881d4dce0c503caac3 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:50:34 2016 -0400 [deliver] Version bump Changes since release 1.13.0: * Version bump fastlane_core dependency for deliver and pilot commit 5d0f4055ef0b216c684d777b2808ba98a4b2c62b Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:49:28 2016 -0400 [pilot] Version bump Changes since release 1.9.0: * Version bump fastlane_core dependency for deliver and pilot commit bf85387d7eee921abc2209be71dafe4b755cf157 Merge: 1861d3e 86c97ed Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:48:23 2016 -0400 Merge pull request #4976 from fastlane/bump-fastlane-core-dependency Version bump fastlane_core dependency for deliver and pilot commit 86c97edb994c34fa17f23b4aa93a9af78f90983c Author: Michael Furtak <mfurtak@twitter.com> Date: Thu Jun 2 15:42:40 2016 -0400 Version bump fastlane_core dependency for deliver and pilot commit 1861d3e2e955e4117cbcd2796a4b0a19e412c59b Merge: 59b36b5 73040f3 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 15:05:59 2016 -0400 Merge pull request #4975 from fastlane/mfurtak-patch-1 Version bump commit 59b36b5dc03c6132186159bf9465ce3e2a9492f9 Merge: 444f4c4 c44185b Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:59:16 2016 -0400 Merge pull request #4974 from fastlane/danger-no-warn-on-version-bump Prevent Danger warning when PR is a version bump commit 73040f3cde22ac9cff412b49865093ed586563bf Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:56:45 2016 -0400 [pilot] Version bump Changes since release 1.8.0: * Add :itc_provider option for deliver and pilot * Make CSV header optional in import_testers (#4119) * Enabled fastlane plugins for all the tools (#4941) commit 444f4c4f682f1a6d757531bc9a253a434b743d1e Merge: 0d65097 cc36bca Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:55:50 2016 -0400 Merge pull request #4973 from fastlane/mfurtak-patch-1 Version bump commit c44185b9b562fe55fe19616012ff43cc9726373c Author: Michael Furtak <mfurtak@twitter.com> Date: Thu Jun 2 14:52:55 2016 -0400 Prevent Danger warn when PR is a version bump commit cc36bcaf401cffa085d72ba704a276f61169171b Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:48:51 2016 -0400 [deliver] Version bump Changes since release 1.12.0: * Add :itc_provider option for deliver and pilot * Ads Apple Developer Id to itunes_transporter.rb. Allows deliver to work with multiple iTunes Providers * Revert "Allow deliver to work with multiple iTunes Providers" (#4961) * Enabled fastlane plugins for all the tools (#4941) * Make deliver setup honor the skip_screenshots flag (#4919) commit 0d65097605b03d4abeee104957c04ee687af672a Merge: 7e3b9e6 5d651ec Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:46:58 2016 -0400 Merge pull request #4972 from fastlane/deliver-pilot-itc-provider Add :itc_provider option for deliver and pilot commit 5d651ecbe5383dc09c8a731ffa6c165618ed8689 Author: Michael Furtak <mfurtak@twitter.com> Date: Thu Jun 2 14:10:37 2016 -0400 Add :itc_provider option for deliver and pilot This provides an explicit option for controlling use of the -itc_provider option in the iTMSTransporter commit 7e3b9e65f18a87578fb8fe5a1e354067c1e8390f Merge: a2698a6 78cb359 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 14:05:54 2016 -0400 Merge pull request #4971 from fastlane/mfurtak-patch-1 Version bump commit 78cb359ed0e75f536f35f9518985ae7d02638eea Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 13:59:07 2016 -0400 [fastlane_core] Version bump Changes since release 0.46.1: * Re-implement -itc_provider support for ItunesTransporter * Ads Apple Developer Id to itunes_transporter.rb. Allows deliver to work with multiple iTunes Providers commit a2698a6900303d9783c7e87664de71d274ee29e2 Merge: b24bdf4 8b62ea6 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 13:54:58 2016 -0400 Merge pull request #4968 from fastlane/itmstransporter-providers Re-implement -itc_provider support for ItunesTransporter commit 8b62ea623e45488cd3e81d08b69985d5975abf6f Author: Michael Furtak <mfurtak@twitter.com> Date: Thu May 19 16:59:18 2016 -0400 Re-implement -itc_provider support for ItunesTransporter commit 3e08461b8b6136c0d39608231d23a05376a88b09 Author: John Grant <johnkgrant@gmail.com> Date: Fri Mar 18 10:52:40 2016 -0400 Ads Apple Developer Id to itunes_transporter.rb. Allows deliver to work with multiple iTunes Providers commit b24bdf4d6e6dc717adef73dfbd70612eda41a241 Merge: eb3f592 0ca84d4 Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 2 12:53:14 2016 -0400 Merge pull request #4949 from fastlane/fastlane-changelog-fix [fastlane] fix changelog_from_git_commits action for cli commit eb3f5922c56f0f91e793090b7c89f3231c976fb4 Author: Jorge Manuel Coelho Amado de Azevedo <jorge.azevedo@guardian.co.uk> Date: Thu Jun 2 17:18:35 2016 +0100 Make CSV header optional in import_testers (#4119) `pilot import` always skips the first row of a CSV file because it expects the format header1,header2,header3 column1,column2,column3 whereas the iTunesConnect bulk import function expects a CSV with format column1,column2,column3 This means that if `pilot import` is used with an iTC CSV, it will skip the first tester in the file. This patch changes the skipping logic. Instead of skipping the first row, it skips any row that doesn't have a valid email on the email column. By making the header effectively optional, `pilot import` can successfully process both an iTC CSV and the resulting CSV of `pilot export`. commit 3fb367145b446c471efe05b6bc9845eced74ede2 Merge: b38fbfa 96e3795 Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 2 12:00:08 2016 -0400 Merge pull request #4964 from thomasjoulin/master Updated cocoapods action to correctly update repo when using cocoapods 1.0 commit 0ca84d4d8faef13a95fffbbeae850e173a7d0490 Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 2 11:24:46 2016 -0400 update danger version commit bc665935196a6082bd53a363b299f44fcecce43f Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 2 10:32:51 2016 -0400 update fastlane core version commit 72e2c83501903f91d5e0db24b9eeaca3893daf36 Author: David Ohayon <ohayon.1@gmail.com> Date: Wed Jun 1 15:52:20 2016 -0400 [fastlane] fix changelog_from_git_commits action for cli commit b38fbfae66faf114cb71ea065934fbc0e4c68b51 Merge: 41745b7 30f124f Author: David Ohayon <ohayon.1@gmail.com> Date: Thu Jun 2 10:49:46 2016 -0400 Merge pull request #4960 from fastlane/KrauseFx-patch-3 Updated danger dependency commit 96e37959fa2916b87d6bcb078e8373b10531138e Author: Thomas Joulin <thomas@themobilelife.com> Date: Thu Jun 2 22:32:38 2016 +0800 Updated cocoapods action to correctly update repo when using cocoapods 1.0 cocoapods 1.0 by default does not run pod repo update on pod install unless --repo-update is set commit 41745b704ee269478694a8fc747e0cc9855831a4 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu Jun 2 00:12:04 2016 -0700 [fastlane_core] Version bump (#4962) * Fixed iTunes Transporter * Fix for CLI based actions with Integer params commit 30c1af82cf837f6b4c41bcaab0a5d509447f84c8 Author: Michael Furtak <michael.furtak@gmail.com> Date: Thu Jun 2 03:04:32 2016 -0400 Revert "Allow deliver to work with multiple iTunes Providers" (#4961) commit 30f124f10a968df3e2059f00bf3ea226fe8adbf0 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 18:05:39 2016 -0700 Updated danger dependency commit 1bb4af181378227af78f22764b35aecf28adf83e Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 17:59:07 2016 -0700 Print proper error message when new 2step is used (#4959) Via https://github.com/fastlane/fastlane/issues/4391 commit 55b8e83a56c846efe2e4879c965a71a9efe84fb8 Author: jvanzummeren <j.van.zummeren@gmail.com> Date: Thu Jun 2 02:50:35 2016 +0200 Added interline spacing to frameit titles (#3989) commit 3da5aa26d368957d96a26974e97c9b30709b7bf4 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 17:49:54 2016 -0700 [fastlane] Version bump (#4958) - Improved newly created plugins - Fixed badge URL (#4948) - Fixed detection of existing plugins (#4957) - Added example `Fastfile` and `Pluginfile` to new plugin so it's easy to try out (#4950) - [testfairy action] enable parameters/options (#4818) commit ef989b741a911a727b93518c1215b933844af4f7 Merge: 29b47a4 8a7e685 Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed Jun 1 20:48:10 2016 -0400 Merge pull request #4957 from fastlane/fix-plugin-generator-gem-check Fix the PluginInfoCollector to check RubyGems for the gem_name commit 8a7e685d06e5cbbc4fdc7c5d9042d59187588c1b Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed Jun 1 20:42:00 2016 -0400 Addressing PR feedback commit 29b47a43bb1812347011bec97d3fa99efc42c07a Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 17:35:08 2016 -0700 Attached Pluginfile to Gemfile for new plugins (#4956) * Attached Pluginfile to Gemfile for new plugins * Improved wording for example code commit 6e11ee75440c2d1ac6c226bae7639478447887ce Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed Jun 1 20:26:40 2016 -0400 Fix the PluginInfoCollector to check RubyGems for the gem_name Previously this was checking RubyGems for the plugin_name, which does not contain the 'fastlane-plugin-' prefix, and is not the full name of the gem. Fixes up the tests to match this behavior and provides a helper method for setting up the stubbed web request. commit a18633a0083b7dd0480a8ec664b94538aaf99c7b Author: Boris Bügling <neonichu2@gmail.com> Date: Wed Jun 1 17:23:23 2016 -0700 Add example to plugin template (#4950) * Add example to plugin template This allows running `bundle exec fastlane test` directly from the generated plugin directory and should encourage people to provide an example `Fastfile`. * Add missing newlines * Add generated `fastlane` files to `.gitignore` * Fix Markdown link commit f422a9b7b4471aafaad25a48f0107c483f4026d0 Author: Jeremiah Njoroge <jnjoroge@gmail.com> Date: Wed Jun 1 15:55:25 2016 -0700 Fix broken urls in Spaceship docs (#4952) commit 5d44365a4269ac4e1365a4075e3dfd134f901d8d Merge: e5b195c 35d68d5 Author: David Ohayon <ohayon.1@gmail.com> Date: Wed Jun 1 18:47:52 2016 -0400 Merge pull request #4922 from fastlane/changelog-fix [fastlane_core] Convert value type of ConfigItems earlier commit 35d68d5ef2541a1b82173286ae5cc74b5c2adeb1 Author: David Ohayon <ohayon.1@gmail.com> Date: Wed Jun 1 15:54:14 2016 -0400 Fix for CLI based actions with Integer params commit e5b195c477960f0c668fa753d87690489b3428b5 Author: Torsten Curdt <tcurdt@vafer.org> Date: Wed Jun 1 23:01:38 2016 +0200 [testfairy action] enable parameters/options (#4818) * enable testfairy parameters/options * make the hound happy * fixed error message * validate metrics and options, use symbols * making the hound happy * fixed more style issues commit 7bf85ad5be19d544fc6bce2d87988ddef9de95d7 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 13:01:40 2016 -0700 Updated fastlane plugin badge URL (#4948) commit 6769c9c762be2f41559667c487bf05a68c693379 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 11:49:30 2016 -0700 [fastlane] Updated fastlane_core dependency (#4944) commit 39cd7d1d2331da6dc958cd898c0d485729ecb0b1 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 11:10:48 2016 -0700 Plugin improvements (#4943) * Show warning when action is overwritten by plugin * More Ruby * Added detection if plugin is already taken on RubyGems commit 3027b706093f6388b30790cda98a8025504d3e68 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 11:04:16 2016 -0700 Enabled fastlane plugins for all the tools (#4941) commit 27126d331a2c769d25b22d30ce8881b8a185a81f Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 08:49:36 2016 -0700 [fastlane_core] Version bump (#4934) * [fastlane_core] Version bump Changes since release 0.45.0: * Hide timestamp by default (#4838) * [fastlane_core] Fix PkgFileAnalyser to shell escape `xar` arguments * [fastlane_core] Helper.fastlane_enabled? now returns true if .fastlan… (#4889) * Continuing work on #3843 * Ads Apple Developer Id to itunes_transporter.rb. Allows deliver to work with multiple iTunes Providers * [fastlane_core] Version bump commit f5885aec963ce3b02bc63e35113ab8a0ba016fcd Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 08:43:55 2016 -0700 [Ready] Plugin manager (#4722) * Added initial Plugins.md * Added initial PluginManager * Minor improvements * Renamed Plugins to Pluginfile * Added note about storing those files in version control * Make use of bundler to detect what plugins are currently being loaded * Fixed spelling mistake Thanks @jinjorge * Added tests for PluginManager * Removed return value for `setup` and `ensure_plugins_attached!` methods Fixes https://github.com/fastlane/fastlane/pull/4722#discussion_r63905341 * Temporary version bump * `bundle update` is now no quiet if verbose is on * Introduced new `available_gems` method Fixed issue with initial setup * Added more tests * Updated and extended docs * Updated from `fastlane_` to `fastlane-plugin` prefix * Ask the user for the plugin name if none is provided * Only ask for user input if no parameter was given * Fixed tests after recent change * Added automatic detection if plugin is available on RubyGems and offer user a way to select custom path / url Added tests * Added generating of available plugins based on RubyGems API ❤️ * Fixed code style issue * Added collecting of third party plugins - Added tracking of third party plugins - Added detection of reference between plugin and action - Added tests * [fastlane_core] Prepare for fastlane plugins - This adds the foundation for 3rd party plugins - Improved code style * Moved fastlane_core tests to other PR * Added tests * Added documentation for plugin source * Fixed plugin manager not using the correct module * Improved plugin docs * Skip development dependencies by default when installing plugins * Removed dead test that didn't actually test things * Added proper catching of SystemExit and similar to cleanly finish fastlane run Tested with `xcake`, which throws a `Xcake::Informative` object * Also track crash when a system exit is used * Fixed code style * Removed bundler code from bin/fastlane * Added more plugins docs * Added docs for `new_plugin` for existing gems * Plugin manager (#4776) * Handle old bundled actions. * Check on one off as well. * Update message. * Added tests for previously bundled fastlane actions * Fixed spelling mistake in Plugins.md * Fixed sample path in Plugins.md * Added test for deprecated actions when plugin is available * Improved plugin docs * Updated RubyGems search query * Added initial Troubleshooting guide * Improved output when adding a plugin * Print command when running fastlane install_plugins or fastlane update_plugins * No more --no-development since it updates the bundler config * Resolved merge conflict * Moved all plugin classes into plugins subfolder * Improved wording and documentation * Renamed Pluginfile constant * Changed "pluginsfile_" to "pluginfile_" * Added plugin summary to see what plugins are loaded * Improved plugin docs * Refactored plugin references to also contain version number Made determine version number a class method with alias to the other method Added constant for troubleshooting guide * fastlane now uses plugins itself to run common ruby tasks * Enabled fastlane plugins for the fastlane's Gemfile * Updated fastlane_core dependency * Added support for hidden ".fastlane" folder * Added new `fastlane search_plugins` command (#4853) * Added new `fastlane search_plugin` command * Added tests * Improved design of search result table * Switched from `search_plugin` to `search_plugins` * Removed now: true from tests * Initial work on plugin generator * Add more structure and tests around plugin generation * Add tests to specifically test validation/fixing behavior * Minimal spec for PluginGeneratoer * Create spec lets * One-time initialization in plugin generator spec * Begin templating files as part of plugin generation Test the correctness of the gemspec by evaluating it and checking its values * Fix hound warnings about exists? * Fix plugin_generator_ui_spec * Address feedback, adapt to new prefix, fix paths * Improve ui object mocking to prevent test hangs if an interactive method is not properly mocked * Fix file generation paths to be correctly start inside the gem name directory * Fix gemspec evaluation during tests to account for its new location relative to the temp directory * Fix plugin info collection to be aware of the changed fastlane plugin prefix value * PluginInfo can generate the require_path from the gem_name * Command name changed to 'new_plugin' * Clean up/suppress rubocop violations * Add email collection to the plugin generator interview * Pre-fill summary, description, homepage in gemspec; reword info collectory questions * LICENSE creation * Add support for collecting gemspec summary and description * Add missing LICENSE file * Accept plugin name during command line call * Define the plugin action class as part of the templating * Make the plugin gem depend on fastlane * Make fastlane a development dependency of the plugin bundle * Add other needed development dependencies to the plugin bundle template * Fix plugin_generator_spec * Add helper file generation to the plugin generator * Add .rspec file to the plugin generator content * Fix failing rubocop offense * Add Gemfile to plugin generator content * Add .gitignore to the plugin generator content * Add main plugin .rb file to the plugin generator content * Add a success message when the plugin generator is done * Add spec helper generation * Add action_spec creation to the plugin generator * Add Rakefile generation * Remove description from PluginInfo model * Add more details the generated README.md * Continue improving the documentation for plugins and generator * Update README template for plugin with badge. * Renamed fastlane logo * Switched from `capitalize` to `fastlane_class` to work with underlines too * Show broken plugins in plugins table * Prepare beta release * Made bundler a fastlane dependency * Prepare next beta release * Optimise and hot badge. * auto detect email and author from git config * Suppress command output for git queries during plugin info collection * Correct incomplete sentence in plugin generator README * Reimplement the PluginGenerator based on dir templating Moves all of the plugin generator template files from a flat directory into one that is actually shaped like the intended destination structure. This allows the PluginGenerator to stop encoding knowledge about the intended structure of the plugin, and just focus on copying and templating logic. The template directory uses %-wrapped variables to allow directory and file names to have variables inserted at run time. Those variable names are used as accessor calls into the PluginInfo object to get replacement values. The tests have been changed to use a plugin name containing an underscore and have been corrected to check for expected values based on fastlane_class transform of the plugin name * Move plugin badge to root fastlane assets dir Update the plugin README to look in this new path * Show error message if fastlane directory is missing * Integrated Club Mate plugin into fastlane setup * Addressed @mfurtak feedback * Fixup "Ensure..." line in Gemfile and Pluginfile * Moved PluginManager object to Fastlane.plugin_manager (#4927) * Moved PluginManager object to Fastlane.plugin_manager * Adressed feedback * Renamed Plugins.md.erb to AvailablePlugins.md.erb * Adressed PR feedback * Added minimum requirement for plugins to Plugins.md * Added install instructions to AvailablePlugins.md * Fixed plugin generator calling wrong class * Commented out the spec.homepage * Updated AvailablePlugins.md * Moved all plugin specs into subfolder * Replaced `install_dependencies` with `install_plugins` * Improved wording * Minor improvements * Updated lane name blacklist to not allow plugin commands * Added auto-import of fastlane actions in plugin specs commit 9ad7806a32574b313df30b496640699b7e8ea0d0 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 08:24:38 2016 -0700 [fastlane] Version bump (#4933) This release adds plugin support to `fastlane`, you can find more information on how to get started at [Plugins.md](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Plugins.md) commit 91356c3cfedbc259783b0984906d7e03ca6ab7a5 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Wed Jun 1 08:24:29 2016 -0700 [fastlane] Updated dependencies (#4935) commit a24b5fd7908708e0c3a6ea13be252080201f0785 Merge: de508c6 b394082 Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed Jun 1 11:07:23 2016 -0400 Merge pull request #4938 from fastlane/jpeg-content-type Add .jpeg to the set of recognized media extensions commit b394082d63e414cad0e29676215867b7a3128079 Author: Michael Furtak <mfurtak@twitter.com> Date: Wed Jun 1 10:48:44 2016 -0400 [spaceship] Add .jpeg to the set of recognized media extensions commit de508c6e704f6588314d0718c2cffee8953f40e1 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 31 19:44:06 2016 -0700 [frameit] Version bump (#4930) commit e8cd346df29f8b15b21286c8f29cb653829a9b5d Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 31 19:43:51 2016 -0700 [frameit] Show full device (#4929) * Add option to show complete device For some apps, the bottom of the screen is important. This allows the developer to specify that this is the case. Frameit will then shrink the screenshot (if necessary) to ensure that the entire device and frame is visible in the framed output. * [frameit] Code style improvements commit 98d43cd19fab84772898f07874c6f952b7d42037 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 31 10:54:17 2016 -0700 [fastlane] Version bump (#4925) * Improved handling of new lines in `increment_build_number` (#4837) * Fix bug in `OneSignal` action (#4892) * Escape Gradle properties (#4897) * `slather` fix `--decimals` flag type * Output changelog in `changelog_from_git_commits` (#4860) * Verify `rest-client` dependency for `sentry` (#4871) * Removed `appium` development dependency and therefore `nokogiri` (#4852) commit c4cd9c53397c5f7bade072fd2a4fdc48b475d671 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 31 10:54:02 2016 -0700 Hide timestamp by default (#4838) * Hide timestamp by default * Switched to FASTLANE_HIDE_TIMESTAMP instead of show timestamp commit 1c26f0648ce2e5ed9e2bd011074482f031acaa5f Author: Nguyen Cao Nhat Linh <nhatlinh95@gmail.com> Date: Tue May 31 10:27:20 2016 -0700 Fix typo in OneSignal action (#4892) that cause the action to fail every time when creating apps with apns commit 0084f9af468aa26b2ff47863bcc3146006198724 Author: Johannes Marbach <johannesmarbach@gmail.com> Date: Tue May 31 19:26:20 2016 +0200 Make deliver setup honor the skip_screenshots flag (#4919) With this commit calling deliver init --skip_screenshots will only download metadata and skip downloading of screenshots. This is useful for cases where the user is only interested in manipulating and uploading the metadata as it spares them the lengthy screenshot download. Before, the only option to skip screenshots during initialization was to CTRL+C the process after the metadata was downloaded. commit c2cce5f04e3a9f72aac0f9961e3e45f2083478eb Merge: d79ccda 5759f3c Author: Michael Furtak <michael.furtak@gmail.com> Date: Tue May 31 12:55:04 2016 -0400 Merge pull request #4923 from fastlane/xar-shell-escape Fix `PkgFileAnalyser` to shell escape `xar` arguments commit 5759f3cd3f88bdea037a88201ef58cd7e975c2e4 Author: Michael Furtak <mfurtak@twitter.com> Date: Tue May 31 12:45:26 2016 -0400 [fastlane_core] Fix PkgFileAnalyser to shell escape `xar` arguments commit d79ccda2cd067130e1beafb0de7cbb5c103120c7 Author: Brian Ganninger <bgannin@users.noreply.github.com> Date: Tue May 31 07:30:15 2016 -0700 Escape Gradle properties (#4897) commit 6fc3bafd2787d11093fe0e82f55aa3a03746269b Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri May 27 14:59:23 2016 -0700 [gym] Print out legacy information every time you run gym (#4890) Fixes https://github.com/fastlane/fastlane/issues/1866 commit 3858d8b242bbb8e1ebca85671bd77a4309157390 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri May 27 14:59:16 2016 -0700 [fastlane] Added syntax highlighting to FAQs (#4891) commit 075d04dab22f5553ae04a2e5f0038a05a428ee8a Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri May 27 14:57:56 2016 -0700 [fastlane_core] Helper.fastlane_enabled? now returns true if .fastlan… (#4889) * [fastlane_core] Helper.fastlane_enabled? now returns true if .fastlane folder is hidden commit 2f7b432783b16d3894f3c94a25cb9c006e3a1176 Merge: b81d4e1 59778a8 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Fri May 27 14:07:35 2016 -0700 Merge pull request #4880 from bootstraponline/slather_action [slather action] Fix --decimals flag type commit b81d4e19dd6375506c8f1d6b3ebd1b7112e685bd Merge: 636e6b6 bc58eb9 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 13:29:17 2016 -0400 Merge pull request #4886 from fastlane/mfurtak-patch-1 Version bump commit bc58eb9b06c1c4eac1f11a977bdd87734ec4a15a Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 13:17:35 2016 -0400 [pilot] Version bump Changes since release 1.7.0: * Add :dev_portal_team_id option commit 636e6b6023940a4819096555f339d53360274abc Merge: 5dae0b1 baca42c Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 13:07:21 2016 -0400 Merge pull request #4883 from fastlane/dev-portal-team-id Add :dev_portal_team_id option to pilot commit baca42cf4f63b0ebfa3b534eb7553f3eaa5e282c Author: Michael Furtak <mfurtak@twitter.com> Date: Fri May 27 11:28:15 2016 -0400 Add :dev_portal_team_id option This helps the iTunes Transporter deal with situations involving multiple teams. commit 59778a8d60609e3e05864f6c88f261543763ecd4 Author: bootstraponline <code@bootstraponline.com> Date: Fri May 27 11:00:26 2016 -0400 [slather action] fix --decimals flag type Fix 'decimals' value must be a String! Found Fixnum instead. commit 5dae0b1a8ffd3439f85fa216727b0efb7fb857af Merge: 9f5bdce f6754ec Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 10:26:17 2016 -0400 Merge pull request #4877 from fastlane/mfurtak-patch-1 Version bump commit f6754ec98c8f93ccbf1e1bf09d4d5ef54ee5ff51 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 10:11:34 2016 -0400 [deliver] Version bump Changes since release 1.11.3: * Ads Apple Developer Id to itunes_transporter.rb. Allows deliver to work with multiple iTunes Providers commit 9f5bdcefbe52268d3c02deaa2a3318ffd54cbd88 Merge: eb5e039 5e3bdd8 Author: Michael Furtak <michael.furtak@gmail.com> Date: Fri May 27 10:09:08 2016 -0400 Merge pull request #4746 from fastlane/multiple-itunes-providers Allow deliver to work with multiple iTunes Providers commit eb5e0394ea5f67ca9eee70ab1a00b0e0e04ca554 Author: Hilton Campbell <hilton.campbell@gmail.com> Date: Thu May 26 18:06:57 2016 -0700 Output changelog in changelog_from_git_commits. (#4860) commit 36472ba3e0073b1ee7db65fc341b89a59ab24899 Author: Bogdan Vitoc <bogdanvitoc@gmail.com> Date: Thu May 26 21:06:22 2016 -0400 Include line number in Artsy link (#4872) commit 2043635f559f2f6bdda26bc40db4c5357fa5e928 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu May 26 15:43:25 2016 -0700 [fastlane] Verify of rest-client dependency for sentry (#4871) Fixes https://github.com/fastlane/fastlane/issues/4848 commit d3bbc18605956ff3c0cf1360fef4d80af6412717 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu May 26 15:42:58 2016 -0700 Removed appium development dependency and therefore nokogiri (#4852) This caused `bundle install` on fastlane to also install nokogiri commit 8bbb33e7cb7cc1e59873daa726363a3f973c20ad Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu May 26 14:55:41 2016 -0700 Made determine_version a class method (#4870) commit 7cfa87c53282a598287e83133ea8ba06ff66e2d3 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Thu May 26 14:55:35 2016 -0700 [fastlane_core] Version bump (#4869) Make `determine_version` a class method Improved unit tests commit 7c2cf85f53f44ed03afb943204c1ef27d3d6154c Merge: 2b33c0c 4f23ae2 Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed May 25 10:21:33 2016 -0400 Merge pull request #4844 from fastlane/mfurtak-patch-1 Version bump commit 4f23ae25e50715412e1b9dba7627f53e214f7af6 Author: Michael Furtak <michael.furtak@gmail.com> Date: Wed May 25 10:15:58 2016 -0400 [snapshot] Version bump Changes since release 1.12.2: * [snapshot] Improve reset_simulators behavior when makinga phone-watch pair * [snapshot] Migrated binary to use commands_generator (#4576) commit 2b33c0c754b976f99d787f9ac1f28163351a2242 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 20:09:45 2016 -0700 [fastlane] Improved handling of new lines in increment_build_number (#4837) * [fastlane] Improved handling of new lines in increment_build_number commit 510a230c1f707366e63e900ac73dad712e75b6c4 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 18:25:22 2016 -0700 [fastlane_core] Added tests for certificate import (#4804) Fixes https://github.com/fastlane/fastlane/issues/4798 kind of commit 3f02f91f41229e9c5883157b141d2a6a790371a2 Merge: da11779 6186e80 Author: Michael Furtak <michael.furtak@gmail.com> Date: Tue May 24 19:02:54 2016 -0400 Merge pull request #4834 from fastlane/snapshot-reset-sims Improve reset_simulators behavior when making a phone-watch pair commit da11779990a8e54a63bed97e4d66bac543fe4d02 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 15:52:14 2016 -0700 [fastlane] Version bump (#4836) commit 1758e9bd466a09b29bd145a63988198feb9282cc Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 15:52:10 2016 -0700 [fastlane] Updated dependencies (#4835) commit 4576b062ea62ddb83d2c2535a8a2222e0545a1ad Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 14:32:53 2016 -0700 [pilot] Version bump (#4811) Added new `skip_waiting_for_build_processing` option :+1: commit 0767f7f57e087d41c279fdfc58336cd9d1d9234d Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Tue May 24 14:31:12 2016 -0700 Added new `skip_waiting_for_build_processing` option (#4812) * Added new `skip_waiting_for_build_processing` option This allows the user to skip the processing time and/or the submission separately Fixes https://github.com/fastlane/fastlane/issues/1463 * Updated PR to address feedback commit 6186e80ca249eebb7cc46ccf4a29364d5063935a Author: Michael Furtak <mfurtak@twitter.com> Date: Tue May 24 16:51:47 2016 -0400 [snapshot] Improve reset_simulators behavior when makinga phone-watch pair commit e76a05fccdcd02b036ad5cf5c15692dd28fe8ec4 Author: Andrea Falcone <andrea@crashlytics.com> Date: Tue May 24 15:44:34 2016 -0400 fastlane_core version bump (#4833) commit bafdcc1d2192fe60e145e72fdedc9e4cce8f7067 Author: Andrea Falcone <andrea@crashlytics.com> Date: Tue May 24 15:35:49 2016 -0400 Re-add Helper.log and add deprecation warning (#4832) commit 8eed401811b08743971a7df682ec9b2893cb55e7 Merge: da7a577 e87e257 Author: Michael Furtak <michael.furtak@gmail.com> Date: Tue May 24 15:32:31 2016 -0400 Merge pull request #4831 from fastlane/mfurtak-patch-1 Version bump commit e87e25775ea6cc8a5feaac283728aedb9f6bc1fa Author: Michael Furtak <michael.furtak@gmail.com> Date: Tue May 24 15:08:07 2016 -0400 Version bump Changes since release 0.7.0: * Fixed scan crash on Mac OS X. Link: https://github.com/fastlane/fastlane/pull/4758#discussion-diff-64371251 * [scan] Added documentation for device grid (#4778) * Made junit result parsing more robust, to deal with additional properties, orders (#4735) commit da7a577112668d8db06192a6c952e66f7cd07cca Merge: 900b6b9 e38efbe Author: Michael Furtak <michael.furtak@gmail.com> Date: Tue May 24 15:05:44 2016 -0400 Merge pull request #4830 from bartoszj/scan_fix Fixed scan crash on Mac OS X. Link: https://github.com/fastlane/fastl… commit e38efbe2517e6ba24e69030169fe53bfbfbc8138 Author: Bartosz Janda <bartosz.janda@gmail.com> Date: Tue May 24 20:44:44 2016 +0200 Fixed scan crash on Mac OS X. Link: https://github.com/fastlane/fastlane/pull/4758#discussion-diff-64371251 commit 900b6b99a5f01e87f909c78e54e8485b985901a4 Author: bootstraponline <code@bootstraponline.com> Date: Tue May 24 11:41:25 2016 -0400 Update slather action with new commands (#4825) commit 89f703281048b100ef52d191de3d258e330b29ac Author: znerol <lo+github@znerol.ch> Date: Tue May 24 08:49:15 2016 +0200 Only query for xcode version on macs (#4631) commit 3af3d9141949e71557c3877125c3c958098bbefd Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 20:10:42 2016 -0700 [match] Version bump (#4809) Prepare new release for https://github.com/fastlane/fastlane/pull/4808 commit d0c988ae1243ddbd2b47867879addf39846cc98d Author: Matthew Riddle <mriddle89@gmail.com> Date: Tue May 24 13:09:49 2016 +1000 Pass git_branch to ChangePassord.update (#4808) * Pass git_branch to ChangePassord.update This resolves an issue where ChangePassword would set the `branch:` parameter to the value of `params[:branch]`, which would be nil. Because we were providing the `branch` argument, the default "master" was being ignored. Causing the GitHelper.clone method to explode when trying to clone a nil branch. * Fix alignment commit b2f6ea1c4e328686159ac3f0c421f824114aac68 Author: Vivien Leroy <vivienleroy@me.com> Date: Tue May 24 05:08:35 2016 +0200 Comment for push_to_git_remote was wrong (#4732) The file was probably copied from add_git_tag.rb and the comment wasn't updated. commit 2e891ee179e485ef5dac4524cf47ead1678f08e6 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 19:46:48 2016 -0700 Show message when trying to enable or disable the crash reporter (#4805) * Show message when trying to enable or disable the crash reporter * Added direct link to GitHub issues Fixed white space commit 57bd1223d30d391d2ee70c2b2293531f9115df2b Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 19:38:48 2016 -0700 [fastlane] Updated fastlane_core dependency (#4806) commit 4c54be9e0b10060dcee448655c0d3e1582b53596 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 16:57:28 2016 -0700 [fastlane_core] Version bump (#4803) Fixed an issue with importing the WWDR certificate commit 3265a8b18e8c4c0ff6e8698cc7ca011ebf3b1db9 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 16:50:40 2016 -0700 [fastlane_core] Fixed import check of WWDR certificate (#4802) commit dfc7ac37bef1087ee5de6ed8ddb49594a53a5f9c Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 16:28:39 2016 -0700 [scan] Added documentation for device grid (#4778) commit 45dce52a4853622e110128a53d27b59219654791 Author: andybest <andybest.net@gmail.com> Date: Mon May 23 21:42:12 2016 +0100 Made junit result parsing more robust, to deal with additional properties, orders (#4735) commit e6759072556f109bfb4fc0192b0e5400647dbaa2 Author: Thomas Ingram <ravinggenius@users.noreply.github.com> Date: Mon May 23 16:11:21 2016 -0400 Sort team selections (#4794) * Sort Apple teams alphabetically for easier deterministic scanning * Memoize Developer Portal team listing response commit 5a8c924414bde8f9f4b55725fe2156ba87b75f2d Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 12:45:28 2016 -0700 [fastlane] Removed open TODOs in tests (#4726) commit 0fd0d9eab76b9aaf91d1f893b23852cd7046627e Author: Julian Nadeau <julian@jnadeau.ca> Date: Mon May 23 14:58:39 2016 -0400 Convert `copy_artifacts` action to Fileutils (#4654) commit f5e05eede8846313bba85c8f0e3a441f3f743cef Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 11:37:17 2016 -0700 [fastlane] Updated dependencies (#4792) To be merged before https://github.com/fastlane/fastlane/pull/4791 commit 64141aeccef87df912d95fbb8fe0206611c63fc1 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 11:37:10 2016 -0700 [fastlane] Version bump (#4791) **New:** * Provide an `xcversion` action to select Xcode via version specifier (#4421) * Adding more options to pod_lib_lint action (#4771) * `scan` can now run scan on multiple devices using the new `devices` option * Added support for carthage `--derived-data`. (#4163) * Prepare `fastlane` foundation to support plugins: https://github.com/fastlane/fastlane/issues/4744 **Improvements:** * Updated platform docs to mention Android by default (#4764) * Updated `xcode-install` depdendency (#4757) * Updated internal dependencies * Replaced remaining .red and raise blocks (#4709) * Don't show private lanes in lanes table (#4690) * Updates `Xcake` Action to support new `xcake make` command. (#4068) * Carthage configuration option and tvOS platform support (#4054) * Fix typo in Copy Artifacts (#4645) * [fastlane] Show custom action message only on verbose mode (#4640) * jira action is now verifying 'jira-ruby' gem installed * Fixed escaping of Keychain path * Removed Sentry crash reporting(#4756) commit abf571c5853833e844c745891e3abd8eab24dc2c Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 11:27:28 2016 -0700 [fastlane_core] Version bump (#4790) * repare for fastlane plugins (#4770) * Removed Sentry (#4756) * Shell escape keychain paths in CertChecker * Replaced remaining .red and raise blocks (#4709) commit 42e995c67f9df76c360071077b10c21feb2d33d9 Author: Andrea Falcone <andrea@crashlytics.com> Date: Mon May 23 14:25:47 2016 -0400 Revert "Added support for invocation from actionscript to gradle.rb" (#4789) commit ac2b37cea87debe05599f6f212d65915ed020742 Author: Felix Krause <KrauseFx@users.noreply.github.com> Date: Mon May 23 11:16:11 2016 -0700 [fastlane_core] Prepare for fastlane plugins (#4770) * [fastlane_core] Prepare for fastlane plugins - This adds the foundation for 3rd party plugins - Improved code style * Added tests commit 71ad1c6ea523c5114e1fcf3f480c204d2f81fba2 Author: nomisRev <nomisRev@users.noreply.github.com> Date: Mon May 23 20:04:32 2016 +0200 Added '.' as default value for project_dir in `gradle` action commit 40405801cd6eb6419177fd29b350c921be3ba61f Author: Siarhei Fiedartsou <siarhei.fedartsou@gmail.com> Date: Mon May 23 21:02:29 2016 +0300 jira action is now verifying 'jira-ruby' gem installed, not 'jira' (#4719) commit 94ed…
Right now the parameters for the testfairy upload are very limited.
This PR enables the following parameters:
Fix #4819