Add option to log output for import_certificate per #1314
#5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Fastlane::Actions.sh(command, log: false) | ||
| Fastlane::Actions.sh(command, log: log_output) |
There was a problem hiding this comment.
Just discard all changes above and replace it with
Fastlane::Actions.sh(command, log: params[:log_output])
|
@KrauseFx applied your suggestion. Thanks! |
|
Looks good, thanks for the contribution! 👍 |
|
🎉 thanks! |
asfalcone
pushed a commit
that referenced
this pull request
Aug 18, 2016
[10:47:00]: Changes since release 1.100.0: * Reduce output when running fastlane -v (#5787) * Device specific warnings in S3 HTML template (#5775) * Add a flag dry_run_email flag to lane generated by init beta (#5772) * typo: sepcific -> specific (#5769) * Choose non interactive (#5738) * Add Circle.md (#5750) * Fixed Scan `destination` parameter (#5744) * [fastlane] latest_testflight_build_number use itc_team_id (#5725) * Do not fail if no version exists on iTunes Connect (#5590) * Add groups support to init beta (#5723) * Skip GitHub issues by default for user_error! (#5622) * [fastlane] Update fastlane_core dependency (#5721) * [fastlane] Fix spelling mistake (#5724) * Add ignore option to commit_version_bump action. (#5541) * Fix #5571, check the absence of 'manifest' in export_options_plist (#5586) * [fastlane] Update metadata of git_tag_exists (#5714) * Disable the rubocop rules for MethodLength and AbcSize (#5715) * Add option to log output for `import_certificate` per #1314 (#5321) * Make commander great again (#5612) * (feat/actions): Add new action 'check if the given git tag exists in the repo or not' (#5555) * Fix documentation about zip action (#5625)
Merged
asfalcone
pushed a commit
that referenced
this pull request
Aug 18, 2016
[10:47:00]: Changes since release 1.100.0: * Reduce output when running fastlane -v (#5787) * Device specific warnings in S3 HTML template (#5775) * Add a flag dry_run_email flag to lane generated by init beta (#5772) * typo: sepcific -> specific (#5769) * Choose non interactive (#5738) * Add Circle.md (#5750) * Fixed Scan `destination` parameter (#5744) * [fastlane] latest_testflight_build_number use itc_team_id (#5725) * Do not fail if no version exists on iTunes Connect (#5590) * Add groups support to init beta (#5723) * Skip GitHub issues by default for user_error! (#5622) * [fastlane] Update fastlane_core dependency (#5721) * [fastlane] Fix spelling mistake (#5724) * Add ignore option to commit_version_bump action. (#5541) * Fix #5571, check the absence of 'manifest' in export_options_plist (#5586) * [fastlane] Update metadata of git_tag_exists (#5714) * Disable the rubocop rules for MethodLength and AbcSize (#5715) * Add option to log output for `import_certificate` per #1314 (#5321) * Make commander great again (#5612) * (feat/actions): Add new action 'check if the given git tag exists in the repo or not' (#5555) * Fix documentation about zip action (#5625)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify that the output of the
import_certificatecommand should be logged to help diagnose what's going wrong with an import. The default value remainsfalseso that the user has to actively opt-in to cause logging to occur, and the option is...optional, so it shouldn't break any existing code.I'll note that my ruby skills are not awesome, so any suggestions on how to make this better are most welcome.