Device specific warnings in S3 HTML template #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve the option to install an iPad only app on an iPhone
| @@ -110,7 +110,8 @@ def self.run(config) | |||
| build_num = info['CFBundleVersion'] | |||
| bundle_id = info['CFBundleIdentifier'] | |||
| bundle_version = info['CFBundleShortVersionString'] | |||
| title = info['CFBundleName'] | |||
| title = info['CFBundleName'] | |||
2 tasks
ChrisChares
force-pushed
the
device-specific-s3-template
branch
3 times, most recently
from
ee284dc
to
50e5fce
Compare
|
Hey @ChrisChares! Thanks for the PR! Would you mind sharing a screenshot of this in action? |
ChrisChares
force-pushed
the
device-specific-s3-template
branch
from
50e5fce
to
409ed0c
Compare
|
@ohwutup Certainly! So we've gone from this, displayed for everything, including iPad only apps To this (iPad only app)
And this (iPhone app)
Note that I changed the verbiage for iPhone only and Universal apps to state you should install on an "iOS device" instead of just "iPhone", as any app marked iPhone only can still be installed on iPads and iPods. You can play around with these sites yourself. Both were generated with my local copy of fastlane running this code. |
|
Thanks for this @ChrisChares! This is awesome! 🚀 |
asfalcone
pushed a commit
that referenced
this pull request
Aug 18, 2016
[10:47:00]: Changes since release 1.100.0: * Reduce output when running fastlane -v (#5787) * Device specific warnings in S3 HTML template (#5775) * Add a flag dry_run_email flag to lane generated by init beta (#5772) * typo: sepcific -> specific (#5769) * Choose non interactive (#5738) * Add Circle.md (#5750) * Fixed Scan `destination` parameter (#5744) * [fastlane] latest_testflight_build_number use itc_team_id (#5725) * Do not fail if no version exists on iTunes Connect (#5590) * Add groups support to init beta (#5723) * Skip GitHub issues by default for user_error! (#5622) * [fastlane] Update fastlane_core dependency (#5721) * [fastlane] Fix spelling mistake (#5724) * Add ignore option to commit_version_bump action. (#5541) * Fix #5571, check the absence of 'manifest' in export_options_plist (#5586) * [fastlane] Update metadata of git_tag_exists (#5714) * Disable the rubocop rules for MethodLength and AbcSize (#5715) * Add option to log output for `import_certificate` per #1314 (#5321) * Make commander great again (#5612) * (feat/actions): Add new action 'check if the given git tag exists in the repo or not' (#5555) * Fix documentation about zip action (#5625)
Merged
asfalcone
pushed a commit
that referenced
this pull request
Aug 18, 2016
[10:47:00]: Changes since release 1.100.0: * Reduce output when running fastlane -v (#5787) * Device specific warnings in S3 HTML template (#5775) * Add a flag dry_run_email flag to lane generated by init beta (#5772) * typo: sepcific -> specific (#5769) * Choose non interactive (#5738) * Add Circle.md (#5750) * Fixed Scan `destination` parameter (#5744) * [fastlane] latest_testflight_build_number use itc_team_id (#5725) * Do not fail if no version exists on iTunes Connect (#5590) * Add groups support to init beta (#5723) * Skip GitHub issues by default for user_error! (#5622) * [fastlane] Update fastlane_core dependency (#5721) * [fastlane] Fix spelling mistake (#5724) * Add ignore option to commit_version_bump action. (#5541) * Fix #5571, check the absence of 'manifest' in export_options_plist (#5586) * [fastlane] Update metadata of git_tag_exists (#5714) * Disable the rubocop rules for MethodLength and AbcSize (#5715) * Add option to log output for `import_certificate` per #1314 (#5321) * Make commander great again (#5612) * (feat/actions): Add new action 'check if the given git tag exists in the repo or not' (#5555) * Fix documentation about zip action (#5625)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Discussed in issue #5774