[scan] Add automatic detection of derived data path #5563

KrauseFx · 2016-08-01T15:26:59Z

This is used to put it into the lane context from the fastlane action. The path is useful when following actions need to access the output of the tests

This is first used in https://github.com/KrauseFx/trainer

This is used to put it into the lane context from the fastlane action. The path is useful when following actions need to access the output of the tests This is first used in https://github.com/KrauseFx/trainer

KrauseFx · 2016-08-01T15:43:20Z

Tests are failing, will take a look as it seems like it behaves differently on Circle

KrauseFx · 2016-08-01T22:45:39Z

Ready for review

mfurtak · 2016-08-02T14:36:23Z

scan/lib/scan/detect_values.rb

+      # => /Users/.../Library/Developer/Xcode/DerivedData/app-bqrfaojicpsqnoglloisfftjhksc/Build/Products/Release-iphoneos
+      # We need to go one folder up, since tests don't run inside 'Release-iphoneos'
+      # but in 'Debug-iphonesimulator'
+      default_path = File.join(File.expand_path("..", default_path), "Debug-iphonesimulator")


You can use File.dirname(default_path) to go up one folder

I know some people in the past have tried to make changes to allow scan to run on real devices. Does this Debug-iphonesimulator path assume too much?

Alright, updated to File.dirname, thanks for letting me know. Great catch regarding running scan on real devices, I'll investigate this now

I don't know what's the status on #5159 in general, and if we want to go finish things up and merge?
It seems like the best approach here is to check if the current run is for the simulator or for the device and then use Debug-iphonesimulator or Debug-iphoneos (or similar)

However the derived data path is set to this, so even for the real device it will just work, it just stores the data in a separate directory.

I wonder if instead it would make sense to just use a fastlane derived data path. I'll give it some more thought tomorrow.

mfurtak · 2016-08-02T14:38:14Z

I added a couple of comments/questions.

mfurtak · 2016-08-03T13:37:30Z

LGTM, if you decide you want to move forward with it.

KrauseFx · 2016-08-10T05:57:08Z

@mfurtak I added one more commit, could you do another review on this? 👍

mfurtak · 2016-08-10T10:31:25Z

👍

* [scan] Add automatic detection of derived data path (#5563) * [scan] Skip showing GitHub issues for build errors (#5609)

* [scan] Add automatic detection of derived data path (#5563) * [fastlane] Summary table show failed action in red (#5672) * Make download_dsyms work for appletvos (#5642) * Add easier access to lane context from actions (#5572) * [Carthage] Add option to pass in specific toolchain * Updated Actions README to clarify last_git_commit (#5627) * Fix require for gem jira-ruby (#5605) * [fastlane] Update spaceship dependency (#5659) * [fastlane] Fix printing verbose information for PluginFetcher (#5670) * [fastlane] Update available plugins (#5671) * [fastlane] Fix plugin search (#5568) * Update Actions file (#5450) * Update versions of tools (#5566) * Improve English in docs output (#5562) * Update carthage action documentation for the dependancies and toolchain options (#5552) * [fastlane] Update dependencies (#5553) * hipchat: escape channel name if it is not escaped yet (#5547) * Fix typo (#5532) * Update import_from_git :branch parameter documentation (#5533) * Update junit_generator to use Helper.gem_path (#5462)

* [scan] Version bump * [scan] Add automatic detection of derived data path (#5563) * [scan] Skip showing GitHub issues for build errors (#5609) * [scan] Version bump

* [scan] Add automatic detection of derived data path (#5563) * [fastlane] Summary table show failed action in red (#5672) * Make download_dsyms work for appletvos (#5642) * Add easier access to lane context from actions (#5572) * [Carthage] Add option to pass in specific toolchain * Updated Actions README to clarify last_git_commit (#5627) * Fix require for gem jira-ruby (#5605) * [fastlane] Update spaceship dependency (#5659) * [fastlane] Fix printing verbose information for PluginFetcher (#5670) * [fastlane] Update available plugins (#5671) * [fastlane] Fix plugin search (#5568) * Update Actions file (#5450) * Update versions of tools (#5566) * Improve English in docs output (#5562) * Update carthage action documentation for the dependancies and toolchain options (#5552) * [fastlane] Update dependencies (#5553) * hipchat: escape channel name if it is not escaped yet (#5547) * Fix typo (#5532) * Update import_from_git :branch parameter documentation (#5533) * Update junit_generator to use Helper.gem_path (#5462)

* upstream/master: (42 commits) [fastlane] Version bump (fastlane#5693) [fastlane] Update scan dependency (fastlane#5691) [scan] Version bump (fastlane#5690) [fastlane] Update internal dependencies (fastlane#5692) [fastlane] Update produce dependency (fastlane#5695) [produce] Version bump (fastlane#5687) [produce] Add waiting for new app to appear (fastlane#5688) [fastlane] Add new team_id option to latest_testflight_build_number (fastlane#5668) [produce] Update spaceship dependency (fastlane#5689) Updated Actions README to clarify last_git_commit (fastlane#5627) [scan] Add automatic detection of derived data path (fastlane#5563) Fix require for gem jira-ruby (fastlane#5605) [match] Add information about the force (fastlane#5658) [fastlane] Update spaceship dependency (fastlane#5659) [deliver] Update spaceship dependency (fastlane#5664) [spaceship] Add test for auto-setting of scaling attribute for screenshots (fastlane#5666) [fastlane] Fix printing verbose information for PluginFetcher (fastlane#5670) [fastlane] Update available plugins (fastlane#5671) Fix a typo in the two factor implementation (fastlane#5682) [fastlane] Summary table show failed action in red (fastlane#5672) ...

cbalea · 2016-08-11T12:29:33Z

@KrauseFx After updating to scan 0.11.0, Slather stops working. I get this error from Slather:

03:27:30 Slathering...
03:27:31 /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:177:in `profdata_coverage_dir': No coverage directory found. (StandardError)
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:410:in `block in find_binary_files'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:409:in `each'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:409:in `find_binary_files'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:344:in `configure_binary_file'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/project.rb:240:in `configure'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/lib/slather/command/coverage_command.rb:51:in `execute'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/clamp-0.6.5/lib/clamp/command.rb:67:in `run'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/clamp-0.6.5/lib/clamp/subcommand/execution.rb:11:in `execute'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/clamp-0.6.5/lib/clamp/command.rb:67:in `run'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/clamp-0.6.5/lib/clamp/command.rb:132:in `run'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/slather-2.3.0/bin/slather:17:in `<top (required)>'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/bin/slather:23:in `load'
03:27:31    from /Users/jenkins/.rbenv/versions/2.2.3/bin/slather:23:in `<main>'
03:27:31 No coverage directory found.
03:27:31 
03:27:31    Are you sure your project is generating coverage? Make sure you enable code coverage in the Test section of your Xcode scheme.
03:27:31    Did you specify your Xcode scheme? (--scheme or 'scheme' in .slather.yml)
03:27:31    If you're using a workspace, did you specify it? (--workspace or 'workspace' in .slather.yml)

My slather.yml file and scan command didn't change. They are the same I use since scan version 0.8.0:
scan --clean --scheme MyCompany -w MyCompany.xcworkspace --code_coverage -o fastlane/test_output/unit

slather.yml:

coverage_service: cobertura_xml
xcodeproj: MyCompany.xcodeproj
workspace: MyCompany.xcworkspace
scheme: MyCompany
output_directory: .
ignore:
  - ExamplePodCode/*
  - ProjectTestsGroup/*
  - appium-tests/*
  - ci/*
  - fastlane/*
  - Pods/*
  - .github/*

cbalea · 2016-08-11T12:49:55Z

Side note: using scan 0.10.1 works.

KrauseFx · 2016-08-11T17:06:18Z

@cbalea thanks for the report. Could you please share the complete output when running scan? Do you use fastlane? Could you create a new issue on the fastlane repo, and follow the template, so that we have all required information 👍

KrauseFx · 2016-08-11T17:09:57Z

@cbalea I think I found the issue, I'll have a fix prepared in a minute

KrauseFx · 2016-08-11T17:22:19Z

@cbalea I pushed #5711, which should fix the issue 👍

Add automatic detection of derived data path

0d3558b

This is used to put it into the lane context from the fastlane action. The path is useful when following actions need to access the output of the tests This is first used in https://github.com/KrauseFx/trainer

KrauseFx added the tool: scan label Aug 1, 2016

Update default_path check

2a0bdfb

KrauseFx added 4 commits August 1, 2016 14:29

Add debug output for circle

86cb152

Update debug output

2c97f05

Simplify directory implementation

fc1a904

Update tests to work on a new machine (e.g. CI)

eb00d27

KrauseFx added 4 commits August 1, 2016 16:39

Move derived_data_path into ensure block

2f6669c

Fix scan tests on an empty machine

a767f38

Simplified and improved derived_data detection

be39fde

Merge branch 'master' into scan-derived-data

fbf4ba0

mfurtak reviewed Aug 2, 2016
View reviewed changes

Use File.dirname instead of expand_path

2829168

KrauseFx self-assigned this Aug 10, 2016

KrauseFx added 2 commits August 9, 2016 22:48

[scan action] Add detecting of plist files and new fail_build option

a528731

Fix code style issue

ea92246

[scan] Reset destination after detecting it

6d59b51

KrauseFx merged commit 497ca7a into master Aug 10, 2016

KrauseFx deleted the scan-derived-data branch August 10, 2016 17:42

KrauseFx added a commit that referenced this pull request Aug 10, 2016

[scan] Version bump

30c7d15

* [scan] Add automatic detection of derived data path (#5563) * [scan] Skip showing GitHub issues for build errors (#5609)

KrauseFx mentioned this pull request Aug 10, 2016

[scan] Version bump #5690

Merged

KrauseFx mentioned this pull request Aug 10, 2016

[fastlane] Version bump #5693

Merged

KrauseFx added a commit that referenced this pull request Aug 10, 2016

[scan] Version bump (#5690)

75700cd

* [scan] Version bump * [scan] Add automatic detection of derived data path (#5563) * [scan] Skip showing GitHub issues for build errors (#5609) * [scan] Version bump

cbalea mentioned this pull request Aug 11, 2016

Slather failing with scan 0.11.0 SlatherOrg/slather#244

Closed

fastlane locked and limited conversation to collaborators Feb 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[scan] Add automatic detection of derived data path #5563

[scan] Add automatic detection of derived data path #5563

KrauseFx commented Aug 1, 2016

KrauseFx commented Aug 1, 2016

KrauseFx commented Aug 1, 2016

mfurtak Aug 2, 2016

mfurtak Aug 2, 2016

KrauseFx Aug 3, 2016

KrauseFx Aug 3, 2016

mfurtak commented Aug 2, 2016

mfurtak commented Aug 3, 2016

KrauseFx commented Aug 10, 2016

mfurtak commented Aug 10, 2016

cbalea commented Aug 11, 2016

cbalea commented Aug 11, 2016

KrauseFx commented Aug 11, 2016

KrauseFx commented Aug 11, 2016

KrauseFx commented Aug 11, 2016

[scan] Add automatic detection of derived data path #5563

[scan] Add automatic detection of derived data path #5563

Conversation

KrauseFx commented Aug 1, 2016

KrauseFx commented Aug 1, 2016

KrauseFx commented Aug 1, 2016

mfurtak Aug 2, 2016

Choose a reason for hiding this comment

mfurtak Aug 2, 2016

Choose a reason for hiding this comment

KrauseFx Aug 3, 2016

Choose a reason for hiding this comment

KrauseFx Aug 3, 2016

Choose a reason for hiding this comment

mfurtak commented Aug 2, 2016

mfurtak commented Aug 3, 2016

KrauseFx commented Aug 10, 2016

mfurtak commented Aug 10, 2016

cbalea commented Aug 11, 2016

cbalea commented Aug 11, 2016

KrauseFx commented Aug 11, 2016

KrauseFx commented Aug 11, 2016

KrauseFx commented Aug 11, 2016