Make download_dsyms work for appletvos #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,8 +201,8 @@ def build_trains | |||
|
|
|||
| # The numbers of all build trains that were uploaded | |||
| # @return [Array] An array of train version numbers | |||
| def all_build_train_numbers | |||
| client.all_build_trains(app_id: self.apple_id).fetch("trains").collect do |current| | |||
| def all_build_train_numbers(platform: nil) | |||
There was a problem hiding this comment.
Adding the new parameter will not work with accessing this from download_dsyms, this have to be 2 separate PRs with a dependency update. So first step would be to split the PR up to be 2 PRs 👍
There was a problem hiding this comment.
I understand that both gems will need to be released, and the dependency will need to be bumped. But why does it require two PRs?
There was a problem hiding this comment.
@tmm1 Good question, that's just how we handled it until now to always be in a consistent state, but I guess you're right
I agree this is a great idea. You have more experience with working on Apple TV apps: Is that something you would/could specify in the Appfile? Or maybe have a new platform in the platform :ios do
lane :appstore do
...
end
end
platform :tv do
lane :appstore do
...
end
endWhat do you think? |
KrauseFx
added a commit
that referenced
this pull request
Aug 10, 2016
* [scan] Add automatic detection of derived data path (#5563) * [fastlane] Summary table show failed action in red (#5672) * Make download_dsyms work for appletvos (#5642) * Add easier access to lane context from actions (#5572) * [Carthage] Add option to pass in specific toolchain * Updated Actions README to clarify last_git_commit (#5627) * Fix require for gem jira-ruby (#5605) * [fastlane] Update spaceship dependency (#5659) * [fastlane] Fix printing verbose information for PluginFetcher (#5670) * [fastlane] Update available plugins (#5671) * [fastlane] Fix plugin search (#5568) * Update Actions file (#5450) * Update versions of tools (#5566) * Improve English in docs output (#5562) * Update carthage action documentation for the dependancies and toolchain options (#5552) * [fastlane] Update dependencies (#5553) * hipchat: escape channel name if it is not escaped yet (#5547) * Fix typo (#5532) * Update import_from_git :branch parameter documentation (#5533) * Update junit_generator to use Helper.gem_path (#5462)
KrauseFx
added a commit
that referenced
this pull request
Aug 10, 2016
* [scan] Add automatic detection of derived data path (#5563) * [fastlane] Summary table show failed action in red (#5672) * Make download_dsyms work for appletvos (#5642) * Add easier access to lane context from actions (#5572) * [Carthage] Add option to pass in specific toolchain * Updated Actions README to clarify last_git_commit (#5627) * Fix require for gem jira-ruby (#5605) * [fastlane] Update spaceship dependency (#5659) * [fastlane] Fix printing verbose information for PluginFetcher (#5670) * [fastlane] Update available plugins (#5671) * [fastlane] Fix plugin search (#5568) * Update Actions file (#5450) * Update versions of tools (#5566) * Improve English in docs output (#5562) * Update carthage action documentation for the dependancies and toolchain options (#5552) * [fastlane] Update dependencies (#5553) * hipchat: escape channel name if it is not escaped yet (#5547) * Fix typo (#5532) * Update import_from_git :branch parameter documentation (#5533) * Update junit_generator to use Helper.gem_path (#5462)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
DOWNLOAD_DSYMS_PLATFORMoption, but maybe it's better to useFASTLANE_PLATFORM_NAMEor theDEFAULT_PLATFORMinstead?cc @KrauseFx