Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcode-install to the fastlane family #5832

Closed

Conversation

neonichu
Copy link
Contributor

No description provided.

@neonichu neonichu changed the title Add xcode-install to the fastlane family WIP: Add xcode-install to the fastlane family Aug 22, 2016
it 'can parse prereleases from 20160705 (alternative page)' do
prereleases = parse_prereleases('20160705-alt')

prereleases.count.should == 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator == used in void context.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

@KrauseFx KrauseFx self-assigned this Aug 22, 2016
end

def xcode
Installer.new.installed_versions.find do |x|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer detect over find.

@neonichu neonichu changed the title WIP: Add xcode-install to the fastlane family Add xcode-install to the fastlane family Aug 23, 2016
@KrauseFx
Copy link
Member

KrauseFx commented Sep 6, 2016

Closing this for now, as we want to keep the tool as a standalone repo for now https://github.com/krausefx/xcode-install 👍

Thanks for handing this over @neonichu cc @neonacho

@KrauseFx KrauseFx closed this Sep 6, 2016
@fastlane fastlane locked and limited conversation to collaborators Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants