Fix Xcode 8 hung-up by making Helper.backticks retriable #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retriable is a simple DSL to retry failed code blocks with randomized exponential backoff time intervals. This is especially useful when interacting external api/services or file system calls. See more about retriable: https://github.com/kamui/retriable/blob/master/README.md
|
#5626 is merged. And it's much better! |
|
We may still want to consider this PR, since I think adding retry behavior may be an important fix for a different problem with Overall the PR looks pretty good, though I think we need to consider whether we're willing to add another dependency to solve the problem. |
|
I see. I reopen this for now. |
| UI.command_output(result) if print | ||
| return result | ||
| def self.backticks(command, print: true, retriable_options: {}) | ||
| require 'retriable' |
There was a problem hiding this comment.
I'd love to keep the old code, and only use the new one if retriable_options is passed. Something like a big if else in the beginning of the method
There was a problem hiding this comment.
Let's wait for @mfurtak's opinion first on if we want to add the dependency, before updating the PR, sorry for chiming it like this
|
Thank you too 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #4059 #5163 #5603
This will solve these issues!
The problem is caused by Xcode 8
Ref: https://forums.developer.apple.com/thread/50372
How to reproduce
See sample project: https://github.com/nafu/Xcode8HungUpTestWithCoreData/tree/master
Notes
I know there is already PR for this #5188, but I try to take another option.