Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for https://github.com/fastlane/fastlane/issues/5163 #5626

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

IngmarStein
Copy link
Contributor

This looks like a good workaround to me.

@IngmarStein IngmarStein changed the title Workaroud for https://github.com/fastlane/fastlane/issues/5163 Workaround for https://github.com/fastlane/fastlane/issues/5163 Aug 7, 2016
@Liquidsoul
Copy link
Contributor

Liquidsoul commented Aug 8, 2016

I've got the same issue, and this change fixes it for me using Xcode 8 beta 4 👍
I hope this will be approved and released soon 🚀

@KrauseFx
Copy link
Member

KrauseFx commented Aug 8, 2016

Very interesting approach, definitely something we could try 👍

@wkoszek
Copy link

wkoszek commented Aug 9, 2016

I'm hitting this problem in my project, but with clean added to this command, if I run it 10 times:

/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild clean -showBuildSettings -workspace Sensorama.xcworkspace -scheme SensoramaTests

It still hangs sometimes.

@KrauseFx
Copy link
Member

So it seems like this doesn't actually fix the issue 😢

@ohayon
Copy link
Contributor

ohayon commented Aug 12, 2016

Going to close this in favor of #5188

@ohayon ohayon closed this Aug 12, 2016
@IngmarStein
Copy link
Contributor Author

This was supposed to fix #5163 (always hangs with Xcode 8), not #4059 (sometimes hangs with Xcode < 8).

@dulacp
Copy link

dulacp commented Aug 16, 2016

I support with @IngmarStein, #5188 seems to have nothing to do with this "always hangs with Xcode 8".
I'm using his fix and it's working very well for this particular issue

@IngmarStein
Copy link
Contributor Author

IngmarStein commented Aug 16, 2016

@ohwutup the underlying bug hasn't been fixed in Xcode 8 Beta 6, but @tokorom's fix still works.

@ianterrell
Copy link

@ohwutup Petitioning for reopening. :)

@ohayon ohayon reopened this Aug 18, 2016
@jblack10101
Copy link

+1

@IngmarStein IngmarStein mentioned this pull request Sep 3, 2016
2 tasks
@lyndsey-ferguson
Copy link
Contributor

@IngmarStein thanks for sharing, will try it

@lyndsey-ferguson
Copy link
Contributor

lyndsey-ferguson commented Sep 6, 2016

It worked the first 2 times and then failed (by hanging again). Ok, now the fourth time works.

@IngmarStein
Copy link
Contributor Author

Interesting. With my Core Data based project, I can easily run xcodebuild clean -showBuildSettingsmany times without hang (e.g. for f in {1..20}; do xcodebuild clean -showBuildSettings > /dev/null 2>&1; done).
Without the clean parameter, xcodebuild from Xcode 8 always hangs.

@lyndsey-ferguson
Copy link
Contributor

I have this running behind Jenkins, that may be the added variable.

@IngmarStein
Copy link
Contributor Author

@lyndsey-ferguson is it possible that you're running into #4059 then? A combination of this PR and #5188 may be required for a complete fix.

@mfurtak
Copy link
Contributor

mfurtak commented Sep 6, 2016

@IngmarStein Thanks for investigating and putting this together 👍

I'm going to take this as-is, but do a follow-up to put this behavior behind a feature switch so that people can opt-in to the change. ✅

@hotbott
Copy link

hotbott commented Sep 7, 2016

Seems to work in my projects and Xcode 7.3.1. Thanks.

@lyndsey-ferguson
Copy link
Contributor

@IngmarStein the commit made by @fcy works for me. I put this in my Gemfile:
gem 'fastlane', :git => 'https://github.com/fcy/fastlane.git', :branch => 'fcy/fix-xcodebuild-show-settings'

@mfurtak
Copy link
Contributor

mfurtak commented Sep 7, 2016

After talking with @KrauseFx, we decided not to put this workaround behind a feature switch. It'll go out live for everyone by default with the next release. 👍

@mfurtak
Copy link
Contributor

mfurtak commented Sep 7, 2016

@lyndsey-ferguson Thanks for chiming in with your test results. 👍 We'll work on merging a retry solution next!

@mfurtak
Copy link
Contributor

mfurtak commented Sep 7, 2016

Hi all, this has been released as part of fastlane_core 0.51.0 🚀

The retry solution from #5188 is also a part of that release.

Thanks very much for your help! Please let us know how it looks 👍

@KrauseFx
Copy link
Member

KrauseFx commented Sep 7, 2016

To test the latest release, please run [sudo] gem update fastlane_core or if you have a Gemfile bundle update.

Please let us know if that fixes the issue for you, so we can push new releases for gym and scan 🚀

@mfurtak
Copy link
Contributor

mfurtak commented Sep 8, 2016

Hi all, gym 1.9.0 💪 and scan 0.12.0 🔍 have been released to pick up these fastlane_core improvements.

To get updated and try them out, please run [sudo] gem update gym scan 🚀

@jacobjennings
Copy link

Doesn't this ignore the -clean parameter, and break incremental builds?

@KrauseFx
Copy link
Member

KrauseFx commented Feb 3, 2017

@jacobjennings Could you submit a new issue for this? 👍

@fastlane fastlane locked and limited conversation to collaborators May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet