[spaceship] Version bump #6208
Merged
[spaceship] Version bump #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release changes the way App Store and Ad Hoc profiles are handled due to a recent API change. If you're using _spaceship_ directly make sure to update your code to consider the following changes: - `Spaceship::ProvisioningProfile::AppStore.all` and `Spaceship::ProvisioningProfile::AdHoc.all` now return the same array of both App Store and Ad Hoc profiles - To distinguish between those profiles at a later point, you can use the new `profile.is_adhoc?` method - The reason for this change is that it's now required to send an additional request per provisioning profile just to get the list of associated certificates and devices. The list of devices is required to detect if it's an Ad Hoc profile. - The _first time_ you call either `.devices`, `.certificates` or `.certificate_valid?` the details request will be sent. Make sure to only call this on profiles you're interested in, as it will take about 400ms per profile - `profile.valid` now doesn't verify the certificate by default any more, you have to call `certificate_valid?` directly, which will take about 400ms to complete unless the certificate is cached - This release also fixed a bug that `spaceauth` wasn't included in the Ruby gem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release changes the way App Store and Ad Hoc profiles are handled due to a recent API change. If you're using spaceship directly make sure to update your code to consider the following changes:
Spaceship::ProvisioningProfile::AppStore.allandSpaceship::ProvisioningProfile::AdHoc.allnow return the same array of both App Store and Ad Hoc profilesprofile.is_adhoc?method.devices,.certificatesor.certificate_valid?the details request will be sent. Make sure to only call this on profiles you're interested in, as it will take about 400ms per profileprofile.validnow doesn't verify the certificate by default any more, you have to callcertificate_valid?directly, which will take about 400ms to complete unless the certificate is cachedspaceauthwasn't included in the Ruby gem