New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply: Add support for apk superseded #9250

Merged
merged 7 commits into from Jun 7, 2017

Conversation

Projects
None yet
9 participants
@capyvara
Contributor

capyvara commented May 23, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Trying to fix #6791

Description

Before uploading a new apk, some update_track's are issued to clean outdated apk versions, following the rules:

  • Remove any version codes that is lesser than the greatest of any later (i.e. production) track
    • Ex: v4 being uploaded to alpha, production has v3, beta has v2, alpha is empty: v2 will be removed from beta, v4 will be added at alpha
  • Also remove any version codes that is lesser than the currently being uploaded if it's in an earlier (i.e. alpha) track
    • Ex: v4 being uploaded to beta, production has v2, beta is empty, alpha has v3: v3 will be removed from alpha, v4 will be added at beta

I never touched any ruby code before, so if any rubyist can review this it will be great.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 23, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented May 23, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label May 23, 2017

@capyvara

This comment has been minimized.

Show comment
Hide comment
@capyvara

capyvara May 23, 2017

Contributor

I signed it!

Contributor

capyvara commented May 23, 2017

I signed it!

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 23, 2017

CLAs look good, thanks!

googlebot commented May 23, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 23, 2017

@KrauseFx KrauseFx changed the title from Apk superseded fix to supply: Add support for apk superseded May 24, 2017

@felipeplets

I was looking for this solution myself. I've checked @capyvara PR and it seems good!

@jhilden

worked for us as well, thank you very much 💚

@ndbroadbent

This comment has been minimized.

Show comment
Hide comment
@ndbroadbent

ndbroadbent May 29, 2017

Contributor

Thanks!! I think I just ran into this when I had an alpha version that was "superseded by production", and I tried directly pushing to the production track.

Contributor

ndbroadbent commented May 29, 2017

Thanks!! I think I just ran into this when I had an alpha version that was "superseded by production", and I tried directly pushing to the production track.

capyvara added some commits May 30, 2017

@ohayon ohayon requested review from mfurtak and hjanuschka May 31, 2017

@capyvara

This comment has been minimized.

Show comment
Hide comment
@capyvara

capyvara Jun 1, 2017

Contributor

I did some cleanup refactoring and added a --check_superseded_tracks command line option, so users need to opt-in using the feature (principle of least surprise).

Contributor

capyvara commented Jun 1, 2017

I did some cleanup refactoring and added a --check_superseded_tracks command line option, so users need to opt-in using the feature (principle of least surprise).

@hjanuschka

@capyvara 🚀 looking good. many thx for your work!
@mfurtak you can look at it too (as requested by @ohayon )

@mfurtak

This comment has been minimized.

Show comment
Hide comment
@mfurtak

mfurtak Jun 1, 2017

Contributor

This seems great, but I will need a little time before I can fully review it. Thanks for your patience!

Contributor

mfurtak commented Jun 1, 2017

This seems great, but I will need a little time before I can fully review it. Thanks for your patience!

@mfurtak

mfurtak approved these changes Jun 7, 2017

@mfurtak

This comment has been minimized.

Show comment
Hide comment
@mfurtak

mfurtak Jun 7, 2017

Contributor

Thanks for this improvement! 🚀

Contributor

mfurtak commented Jun 7, 2017

Thanks for this improvement! 🚀

@mfurtak mfurtak merged commit 73c75d2 into fastlane:master Jun 7, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Jun 8, 2017

Hey @capyvara 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot commented Jun 8, 2017

Hey @capyvara 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@KrauseFx KrauseFx referenced this pull request Jun 12, 2017

Merged

Version bump to 2.38.0 #9439

KrauseFx added a commit that referenced this pull request Jun 12, 2017

KrauseFx added a commit that referenced this pull request Jun 12, 2017

@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Jun 13, 2017

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

fastlane-bot commented Jun 13, 2017

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

@capyvara capyvara deleted the capyvara:apk-superseded-fix branch Jun 13, 2017

@capyvara capyvara referenced this pull request Jun 13, 2017

Merged

Apk check superseded tracks #9459

4 of 4 tasks complete
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Jun 16, 2017

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

fastlane-bot commented Jun 16, 2017

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

davidchristiandy added a commit to davidchristiandy/fastlane that referenced this pull request Sep 5, 2017

[supply] Add check_superseded_tracks option (#9250)
* Bumped google-api-client to 0.11.xx
* Get track version codes return empty array instead of error when trackEmpty
* Check superseded tracks
* Better print removed versions
* Command line option check_superseded_tracks

davidchristiandy added a commit to davidchristiandy/fastlane that referenced this pull request Sep 5, 2017

@fastlane fastlane locked and limited conversation to collaborators Sep 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.