Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply: Add support for apk superseded #9250

Merged
merged 7 commits into from
Jun 7, 2017
Merged

supply: Add support for apk superseded #9250

merged 7 commits into from
Jun 7, 2017

Conversation

capyvara
Copy link
Contributor

@capyvara capyvara commented May 23, 2017 •
edited
Loading

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Trying to fix #6791

Description

Before uploading a new apk, some update_track's are issued to clean outdated apk versions, following the rules:

  • Remove any version codes that is lesser than the greatest of any later (i.e. production) track
    • Ex: v4 being uploaded to alpha, production has v3, beta has v2, alpha is empty: v2 will be removed from beta, v4 will be added at alpha
  • Also remove any version codes that is lesser than the currently being uploaded if it's in an earlier (i.e. alpha) track
    • Ex: v4 being uploaded to beta, production has v2, beta is empty, alpha has v3: v3 will be removed from alpha, v4 will be added at beta

I never touched any ruby code before, so if any rubyist can review this it will be great.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@capyvara
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@KrauseFx KrauseFx added the tool: supply upload_to_playstore label May 24, 2017
@KrauseFx KrauseFx changed the title Apk superseded fix supply: Add support for apk superseded May 24, 2017
@capyvara capyvara mentioned this pull request May 24, 2017
Closed
2 tasks
felipeplets
felipeplets approved these changes May 29, 2017
View reviewed changes
Copy link

@felipeplets felipeplets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking for this solution myself. I've checked @capyvara PR and it seems good!

jhilden
jhilden approved these changes May 29, 2017
View reviewed changes
Copy link

@jhilden jhilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for us as well, thank you very much 💚

@ndbroadbent
Copy link
Contributor

ndbroadbent commented May 29, 2017 •
edited
Loading

Thanks!! I think I just ran into this when I had an alpha version that was "superseded by production", and I tried directly pushing to the production track.

@ohayon ohayon requested review from mfurtak and hjanuschka May 31, 2017 19:25
@capyvara
Copy link
Contributor Author

capyvara commented Jun 1, 2017

I did some cleanup refactoring and added a --check_superseded_tracks command line option, so users need to opt-in using the feature (principle of least surprise).

hjanuschka
hjanuschka approved these changes Jun 1, 2017
View reviewed changes
Copy link
Collaborator

@hjanuschka hjanuschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capyvara 🚀 looking good. many thx for your work!
@mfurtak you can look at it too (as requested by @ohayon )

@mfurtak
Copy link
Contributor

mfurtak commented Jun 1, 2017

This seems great, but I will need a little time before I can fully review it. Thanks for your patience!

@mfurtak
Copy link
Contributor

mfurtak commented Jun 7, 2017

Thanks for this improvement! 🚀

@mfurtak mfurtak merged commit 73c75d2 into fastlane:master Jun 7, 2017
@fastlane-bot
Copy link

Hey @capyvara 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@KrauseFx KrauseFx mentioned this pull request Jun 12, 2017
Merged
KrauseFx added a commit that referenced this pull request Jun 12, 2017
@KrauseFx
Revert "[supply] Add check_superseded_tracks option (#9250)"
dcf94ba 
This reverts commit 73c75d2.
@KrauseFx KrauseFx mentioned this pull request Jun 12, 2017
Merged
KrauseFx added a commit that referenced this pull request Jun 12, 2017
@KrauseFx
Revert "[supply] Add check_superseded_tracks option (#9250)" (#9444)
0a7a248 
This reverts commit 73c75d2.
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

@capyvara capyvara deleted the apk-superseded-fix branch June 13, 2017 20:59
@capyvara capyvara mentioned this pull request Jun 13, 2017
Merged
4 tasks
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@capyvara
[supply] Add check_superseded_tracks option (fastlane#9250)
e5e2ce2 
* Bumped google-api-client to 0.11.xx
* Get track version codes return empty array instead of error when trackEmpty
* Check superseded tracks
* Better print removed versions
* Command line option check_superseded_tracks
dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@KrauseFx
Revert "[supply] Add check_superseded_tracks option (fastlane#9250)" (f…
e15d6bb 
…astlane#9444)

This reverts commit 73c75d2.
@fastlane fastlane locked and limited conversation to collaborators Sep 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhilden jhilden jhilden approved these changes

@felipeplets felipeplets felipeplets approved these changes

@mfurtak mfurtak mfurtak approved these changes

@hjanuschka hjanuschka hjanuschka approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: supply upload_to_playstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Play Store APK version code conflicts between tracks...
9 participants
@capyvara @googlebot @ndbroadbent @mfurtak @fastlane-bot @jhilden @felipeplets @hjanuschka @KrauseFx