get reference to fastlane folder the more correct way #9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrauseFx
reviewed
Jun 14, 2017
| @@ -240,6 +240,10 @@ def self.fastlane_enabled? | |||
| @enabled ||= !FastlaneCore::FastlaneFolder.path.nil? | |||
| end | |||
|
|
|||
| def self.fastlane_enabled_folder_path | |||
There was a problem hiding this comment.
A comment here would be great to describe what the method does
KrauseFx
approved these changes
Jun 14, 2017
Fixes: deliver/lib/deliver/commands_generator.rb:38:5: W: Lint/UnneededDisable: Unnecessary disabling of Metrics/PerceivedComplexity.
Describes fastlane_enabled_folder_path
Added new line
|
@KrauseFx omg when are we getting fastlane fidget spinners? |
|
Hey @taquitos 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.39.0 🚀 |
|
Congratulations! 🎉 This was released as part of fastlane 2.39.0 🚀 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
dvdchr
pushed a commit
to dvdchr/fastlane
that referenced
this pull request
Sep 5, 2017
* get reference to fastlane folder the more correct way * Sure rubocop. Whatever. Fixes: deliver/lib/deliver/commands_generator.rb:38:5: W: Lint/UnneededDisable: Unnecessary disabling of Metrics/PerceivedComplexity. * Added comment Describes fastlane_enabled_folder_path * Cleaned up rubocop's mess Added new line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Update to get the fastlane folder the more correct way (that will even find it if the folder starts with a .)