Removes session authentication

[conniechu929]

Removed the ability to authenticate with a username and password. Users are required to use api_key in order to be authorized.

[Integralist]

Thanks @conniechu929 for the PR.

I've left only a few minor comments for you.

[Integralist]

Was this assertion always failing? As I don't see pass set anywhere (it looks like the variable was always named password).

[Integralist]

I've not written Ruby in many years but a quick reduced test case would suggest this should have been a syntax error. Something along the lines of:

undefined local variable or method `pass'

[conniechu929]

You're right. I think these were passing before because it was stubbing an Unauthorized error. The error that surfaced wasn't from the undefined variable so I'm assuming it didn't matter that the pass wasn't being set anywhere. However, I think I'm going to fix all of them to reference password because it'll be clear to everyone what the errors should be.

[stevendaniels]

This is a bit more problematic: pass is a minitest assertion:

# File lib/minitest/assertions.rb, line 622
def pass _msg = nil
  assert true
end

Here's an example of the behavior of pass

# foo_test.rb                                                                                     
require 'minitest/autorun'

class FooTest < Minitest::Test
  def test_pass
    pass
  end

  def test_nothing
  end
end

$ ruby foo_test.rb                                               
Run options: --seed 55807

# Running:

..

Finished in 0.000752s, 2659.5740 runs/s, 1329.7870 assertions/s.

2 runs, 1 assertions, 0 failures, 0 errors, 0 skips

An empty test produces no assertions, but pass creates one assertion which always passes.

Changing this to password seems like a good idea.

[conniechu929]

Thanks @stevendaniels for that confirmation!

[stevendaniels]

Looks good.

[stevendaniels]

🥇

[jeneve]

the code looks great to me! The last thing I think is to bump the major version and add an entry to the changelog that includes migration instructions. There is also a file called HISTORY.md I am unsure if you need to add to that also?

[Integralist]

LGTM. Thanks @conniechu929 ! ❤️

Only other thing I would ask is if we could document the release process in a RELEASE.md file. We do this in our other API clients (e.g. https://github.com/fastly/terraform-provider-fastly/blob/master/RELEASE.md) as it helps people (like myself 🙂) know how to cut a release for this updated code.