Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish.rs to top-level workspace #20

Closed
cratelyn opened this issue Jul 12, 2021 · 2 comments
Closed

Add publish.rs to top-level workspace #20

cratelyn opened this issue Jul 12, 2021 · 2 comments
Labels
ci Relates to continuous integration maintenance Maintenance and gardening

Comments

@cratelyn
Copy link
Contributor

Today, we have a helper script to check that all of the packages in the workspace are publishable. This script was heavily inspired from a similar facility in wasmtime, which goes out of its way to avoid incurring any dependencies.

In conversation with @aturon however, we agreed that there are some benefits to allowing dependencies to exist. For example, the code used to parse out the Cargo.toml manifest is a bit ungainly. Additionally, we can use something like clap to handle parsing out command-line options.

@cratelyn cratelyn added ci Relates to continuous integration maintenance Maintenance and gardening labels Jul 12, 2021
@mgattozzi
Copy link
Contributor

@cratelyn I'm going through and triaging issues and I think we can close this one given we have the script available. Is that correct or is there more functionality we want here?

https://github.com/fastly/Viceroy/blob/main/scripts/publish.rs

@cratelyn
Copy link
Contributor Author

cratelyn commented Sep 6, 2022

i'm content to close this. while the issue itself isn't addressed, this is a very low priority and probably not worth the effort today.

@cratelyn cratelyn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Relates to continuous integration maintenance Maintenance and gardening
Projects
None yet
Development

No branches or pull requests

2 participants