Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve over HTTPS #50

Open
acme opened this issue Jul 20, 2021 · 4 comments
Open

Serve over HTTPS #50

acme opened this issue Jul 20, 2021 · 4 comments

Comments

@acme
Copy link
Collaborator

acme commented Jul 20, 2021

👋 Have we considered serving fastly compute serve over HTTPS instead of HTTP? My application isn’t working because I set HTTPS-only cookies, and I don’t want to make too many changes to the application so that it works locally.

Here's a screenshot from Google Chrome developer tools showing a warning about the Set-Cookie header:

Screenshot_2021-07-20_at_10_18_09

@fgsch
Copy link
Member

fgsch commented Jul 20, 2021

This might be another form of #12 .

@mgattozzi
Copy link
Contributor

mgattozzi commented Jul 20, 2021

It might be related, but I don't think this is necessarily the same. From the README the limitation #12 is trying to address is that "Information about the TLS connection from the client is not available". This issue could be implemented without exposing that information to a guest. If I'm understanding #12 it's more for functions in our SDK like get_tls_client_hello which in turn make hostcalls that as we can see here in Viceroy are not handled yet. Implementing this issue would be a necessary first step to exposing this information to Viceroy users and address what #12 is about.

@fgsch
Copy link
Member

fgsch commented Jul 20, 2021

@mgattozzi Yup, totally. What I meant in my rather terse comment (sorry!) is that comparatively speaking #12 is quite small, so implementing the foundations for #12 will also cover this, but you are 100% correct and I appreciate the clarification 👍

@mgattozzi
Copy link
Contributor

Ah I see! No worries @fgsch 😄 Was adding some clarification, especially for those who might not be familiar with the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants