You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a couple of configs where we first deserialize to a Raw config type and then call try_into to convert to the validated and massaged final config type. This is because we're only using the default Deserialize implementation for config types. We can remove this extra intermediate step and type by either creating a Deserialize implementation ourselves or by using things like deserialize_with for certain fields as needed.
This isn't a high priority item, but would help make the code base a bit easier to work with in some ways. I'm happy to explain in more detail what needs to be done if someone needs more context/guidance in order to understand what to do or if someone does know how to do it then I will review that PR for them. Otherwise I can get around to this at some point in the future if there isn't interest in doing it.
The text was updated successfully, but these errors were encountered:
@mgattozzi looks good!
Could you give some example part where Raw type is being used for deserialization?
(I could find in config.rs, but please let me know if there's more)
We have a couple of configs where we first deserialize to a
Raw
config type and then calltry_into
to convert to the validated and massaged final config type. This is because we're only using the defaultDeserialize
implementation for config types. We can remove this extra intermediate step and type by either creating aDeserialize
implementation ourselves or by using things likedeserialize_with
for certain fields as needed.This isn't a high priority item, but would help make the code base a bit easier to work with in some ways. I'm happy to explain in more detail what needs to be done if someone needs more context/guidance in order to understand what to do or if someone does know how to do it then I will review that PR for them. Otherwise I can get around to this at some point in the future if there isn't interest in doing it.
The text was updated successfully, but these errors were encountered: