Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow host overrides in TOML configuration #9

Closed
cratelyn opened this issue Jul 12, 2021 · 3 comments
Closed

Allow host overrides in TOML configuration #9

cratelyn opened this issue Jul 12, 2021 · 3 comments
Assignees
@fgsch
Labels
feature-ux Concerning ergonomics and ease-of-use

Comments

@cratelyn
Copy link
Contributor

One option exposed in Fastly's management UI is the ability to provide an "override host." See this guide for more information. The core premise is that the host header will be rewritten with a different host than is in the outbound URL.

We should expose a setting in our TOML schema to do the same thing when running a program locally.
@cratelyn cratelyn added the feature-ux Concerning ergonomics and ease-of-use label Jul 12, 2021
@aturon
Copy link
Contributor

aturon commented Jul 14, 2021

@fgsch plans to take this on!

Some notes:

fgsch added a commit to fgsch/Viceroy that referenced this issue Jul 19, 2021
@fgsch
Allow host overrides in TOML configuration
457aebd 
This adds a new field to the backend definition, override_host,
allowing to override the Host header that will be send to the
backend.

Addresses fastly#9.
fgsch added a commit to fgsch/Viceroy that referenced this issue Jul 19, 2021
@fgsch
Allow host overrides in TOML configuration
a1091bb 
This adds a new field to the backend definition, override_host,
allowing to override the Host header that will be send to the
backend.

Addresses fastly#9.
@fgsch fgsch mentioned this issue Jul 19, 2021
Merged
fgsch added a commit to fgsch/Viceroy that referenced this issue Jul 19, 2021
@fgsch
Allow host overrides in TOML configuration
5f98e8b 
This adds a new field to the backend definition, override_host,
allowing to override the Host header that will be sent to the
backend.

Addresses fastly#9.
fgsch added a commit to fgsch/Viceroy that referenced this issue Jul 19, 2021
@fgsch
Allow host overrides in TOML configuration
786c77e 
This adds a new field to the backend definition, override_host,
allowing to override the Host header that will be sent to the
backend.

Addresses fastly#9.
@fgsch
Copy link
Member

fgsch commented Jul 20, 2021

Implemented in #48 .

@fgsch fgsch closed this as completed Jul 20, 2021
@fgsch fgsch reopened this Jul 20, 2021
@cratelyn
Copy link
Contributor Author

I think this issue is done. Thanks again Federico!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgsch fgsch

Labels
feature-ux Concerning ergonomics and ease-of-use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fgsch @aturon @cratelyn