Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveIdentityOps does not correctly handle identity operations following fork-nodes #86

Closed
iksnagreb opened this issue Nov 14, 2023 · 0 comments · Fixed by #87
Closed
Labels
bug Something isn't working

Comments

@iksnagreb
Copy link
Contributor

This problem reported over at FINN belongs here, see Xilinx/finn#878 (comment).

RemoveIdentityOps seems to be broken if the identity operation directly follows a fork-node. It seemingly rewires the fork-node output only into that branch containing the identity op, disconnecting the others. Currently this happens when using packed input projections in multi-head scaled dot-product attention. I will try to fix this soon, probably only requires an additional test added to the remove_node_and_rewire utility function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant