Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] 兼容pytorch的DataLoader,替换Batch为DataSetIter #166

Merged
merged 6 commits into from
Jun 17, 2019
Merged

Conversation

choosewhatulike
Copy link
Member

@choosewhatulike choosewhatulike commented Jun 15, 2019

Description:兼容pytorch的DataLoader,替换Batch为DataSetIter

  • [new] DataSetIter, TorchLoaderIter, BatchIter
  • [remove] Batch
  • [change] Trainer 的API

Main reason: 使Trainer更快也更易使用

@修改过这个文件的人
@核心开发人员

@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #166 into dev0.5.0 will increase coverage by 0.27%.
The diff coverage is 87.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev0.5.0     #166      +/-   ##
============================================
+ Coverage     64.68%   64.96%   +0.27%     
============================================
  Files            88       88              
  Lines          9083     9107      +24     
============================================
+ Hits           5875     5916      +41     
+ Misses         3208     3191      -17
Impacted Files Coverage Δ
fastNLP/__init__.py 100% <ø> (ø) ⬆️
test/models/model_runner.py 98.75% <100%> (ø) ⬆️
fastNLP/core/__init__.py 100% <100%> (ø) ⬆️
test/core/test_trainer.py 95.71% <100%> (ø) ⬆️
test/core/test_callbacks.py 100% <100%> (ø) ⬆️
test/core/test_batch.py 100% <100%> (ø) ⬆️
fastNLP/core/predictor.py 73.17% <100%> (ø) ⬆️
test/test_tutorials.py 100% <100%> (ø) ⬆️
fastNLP/modules/encoder/embedding.py 21.33% <50%> (ø) ⬆️
fastNLP/core/tester.py 85.88% <62.5%> (-2.87%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4c3c2...4b5113c. Read the comment docs.

@yhcc yhcc merged commit 66f5139 into dev0.5.0 Jun 17, 2019
@WillQvQ WillQvQ deleted the batch branch October 30, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants