Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize phone numbers #701

Open
johnnyshields opened this issue Jan 18, 2018 · 3 comments
Open

Internationalize phone numbers #701

johnnyshields opened this issue Jan 18, 2018 · 3 comments
Milestone

Comments

@johnnyshields
Copy link
Contributor

  • All phone inputs should use: https://github.com/jackocnr/intl-tel-input
  • Phone numbers should be stored in and validated as E.164 format, e.g. "+12061234567" for a US phone number.
  • Existing phone data which doesn't start with a plus should be displayed as is, and the user should see a message "please migrate your phone data to E.164 format"
@CloCkWeRX
Copy link
Member

I like the control, but that's going to be a lot of data migration for a lot of people, some who would only do business within their own country.
When this lands, we'll want a lot of data migration helpers/rake tasks/etc to make it as painless as possible

@steveyken
Copy link
Member

steveyken commented Jan 19, 2018 via email

@CloCkWeRX CloCkWeRX added this to the 0.20.0 milestone Jan 20, 2018
@johnnyshields johnnyshields reopened this Jan 20, 2018
@johnnyshields
Copy link
Contributor Author

@CloCkWeRX @steveyken it's a best practice to store all phone numbers in the DB as E.164 format (we can add a seperate "phone_extension" field as extensions aren't included in E.164)

I'm fine add a "international phone" option in the settings but I think it should be set to true for newly created apps when you run "ffcrm:setup"

@johnnyshields johnnyshields modified the milestones: 0.20.0, 0.19.0 Jan 20, 2018
@CloCkWeRX CloCkWeRX modified the milestones: 0.19.0, 0.20.0 Nov 8, 2019
@CloCkWeRX CloCkWeRX modified the milestones: 0.20.0, 0.21.0 May 11, 2021
@CloCkWeRX CloCkWeRX modified the milestones: 0.21.0, 0.23.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants