Performance: Freeze string literal #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix one more frozen string literal case
|
@CloCkWeRX this is ready to merge |
CloCkWeRX
reviewed
Jan 5, 2018
.travis.yml
Outdated
|
|
||
| matrix: | ||
| exclude: | ||
| - rvm: 2.3.3 |
There was a problem hiding this comment.
Probably better to just update this exclude to 2.3.6, ditto below for the unlikely chance we bring in mysql/sqlite regression
CloCkWeRX
approved these changes
Jan 5, 2018
|
@CloCkWeRX that's fine, let's go ahead and release 0.16.0 then as I have a lot more improvements in the pipeline. |
|
FYI I'm using the current master in production now. |
johnnyshields
changed the title
|
Weird. Travis builds increased by an hour after this: Hopefully, its just something on the underlying travis infrastructure |
|
Ah, we swapped from exclude to allow failures, meaning run time went way up; then ran on two rubies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add adds Ruby 2.4 to Travis