Undo deprecation of coordinate conversion methods #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9be855.
Ditch the old implementations of the coordinate conversion methods and use pymap3d functions under the hood. Pass longitude and latitude arguments and get the returns in the proper order.
Add back the code for the coordinate conversions. It's not much code, we have the tests already, and pymap3d may not be a very stable dependency when it comes to their ellipsoid representation.
|
@santisoler after looking this over a bit, I thought it was best to not add pymap3d as a direct dependency. It's not a lot of code, we already have in the code base + tests, and pymap3d may decide to change their ellipsoid. So let's keep this in here for convenience but make it possible to do other conversions with pymap3d. We may have to revisit this when we do layered ellipsoids since we'd need to the Cartesian conversion as well. But that can come later. I pushed an update to the tutorial as well to use our methods and then have a section for pymap3d. |
|
Need to wait for #144 since pymap3d>2.9 doesn't exist for 3.6. |
leouieda
changed the title
|
Also best to not add a new dependency during a bug fix release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Deprecate the coordinate conversion methods (#126)" to ditch the
deprecation warnings for the coordinate conversion methods.
Restore the coordinate conversion methods using the
pymap3dfunctions underthe hood. Pass the longitude and latitude arguments and get the returns in the
proper order. Add
pymap3das a required dependency of Boule.Relevant issues/PRs:
#126, fatiando/harmonica#350,
Fatiando Dev Meeting of 2022-09-28