Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pymap3d for coordinate conversions #350

Closed
wants to merge 3 commits into from
Closed

Use pymap3d for coordinate conversions #350

wants to merge 3 commits into from

Conversation

santisoler
Copy link
Member

Replace the usage of boule.Ellipsoid.geodetic_to_spherical and
boule.Ellipsoid.spherical_to_geodetic methods for the pymap3d
functions. The Boule methods will be deprecated in the near future.
Add pymap3d as a requirement for running the tests and building the
docs. Update docs and tests.

Relevant issues/PRs:

Fixes #346

Replace the usage of `boule.Ellipsoid.geodetic_to_spherical` and
`boule.Ellipsoid.spherical_to_geodetic` methods for the `pymap3d`
functions. The Boule methods will be deprecated in the near future.
Add `pymap3d` as a requirement for running the tests and building the
docs. Update docs and tests.
@santisoler
Copy link
Member Author

In the Fatiando Dev Meeting of 2022-09-28 we decided to restore the coordinate conversions methods in Boule wrapping the pymap3d functions. So I'm closing this PR since we won't need to apply these changes in Harmonica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pymap3d functions for coordinate conversions
1 participant