Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS expired cert test is showing false positive #655

Open
grafnu opened this issue Sep 23, 2020 · 2 comments
Open

TLS expired cert test is showing false positive #655

grafnu opened this issue Sep 23, 2020 · 2 comments
Assignees

Comments

@grafnu
Copy link
Collaborator

grafnu commented Sep 23, 2020

Something's wrong with the expired TLS test, as per previous email discussion.

It seems that it is passing when it should not. The test is reaching out to an invalid URL so it should just fail outright, since it's not an expired cert that it's testing, but rather there's no traffic at all. Not clear why this is happening.

@pisuke
Copy link
Collaborator

pisuke commented Oct 19, 2020

@jhughesbiot have you had a chance to check this behaviour?

@jhughesbiot
Copy link
Collaborator

Addressed in PR #760 for TLS 1.2 client test. TLS 1.3 requires additional failure criteria be determined before it can be addressed for that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants