Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauge database error handling #353

Closed
gizmoguy opened this issue Jan 9, 2017 · 2 comments
Closed

Gauge database error handling #353

gizmoguy opened this issue Jan 9, 2017 · 2 comments
Labels
enhancement

Comments

@gizmoguy
Copy link
Member

gizmoguy commented Jan 9, 2017

At the moment if we get a bad response from a database backend (i.e influxdb) gauge will crash with no error.

If we get the username/password wrong we will crash, if we get an error from influxdb on a query (such as bad datatype) we will crash.

We should add some error handling to the database connection and queries.
This was referenced Jan 9, 2017
Closed
Merged
@anarkiwi
Copy link
Member

anarkiwi commented Mar 6, 2017

2380dc3 adds basic exception handling for InfluxDB.

Adding more tests also

@anarkiwi
Copy link
Member

anarkiwi commented Mar 9, 2017

I have added the most basic possible tests (database down/up and that POST succeeds).
Could use more but at least the basics are there now.

@anarkiwi anarkiwi closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gizmoguy @anarkiwi