New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldn't we be merging this into all requests rather than only including this behavior if they use the defaultClient? #8

Closed

breathe opened this issue Jan 24, 2023 · 1 comment · Fixed by #10

breathe commented Jan 24, 2023 •

edited

Loading

@cynicaljoy @cleve-fauna

fauna-go/client.go

Lines 122 to 125 in 2784d07

    
           	"X-Runtime-Environment-OS": fingerprinting.EnvironmentOS(), 
        
           	"X-Runtime-Environment":    fingerprinting.Environment(), 
        
           	"X-Go-Version":             fingerprinting.Version(), 
        
           }),

Just thinking about the loss of this info in the (common case?) of a user who doesn't use the DefaultClient

Contributor

cynicaljoy commented Jan 25, 2023

good catch - we should move the headers we want to ensure are always on the clients to

fauna-go/client.go

Line 156 in 2784d07

headers: map[string]string{},

cynicaljoy mentioned this issue

Moved headers #10

Merged

cynicaljoy closed this as completed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment