Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/install script forces use of ./venv virtualenv, impossible to use with virtualenvwrapper #28

Open
2 tasks done
forsberg opened this issue Nov 13, 2020 · 1 comment
Open
2 tasks done

scripts/install script forces use of ./venv virtualenv, impossible to use with virtualenvwrapper #28

forsberg opened this issue Nov 13, 2020 · 1 comment

Comments

@forsberg
Copy link
Contributor

Checklist

  • I have included information about relevant versions
  • I have verified that the issue persists when using the master branch of Faust.

Steps to reproduce

Check out faust-streaming 40237be, then

./scripts/install
./scripts/lint
./scripts/tests
<runs a lot of tests>
scripts/coverage: 11: codecov: not found

I'm not familiar with codecov, but I guess it should be run only if the environment variable CODECOV_TOKEN is set?
@forsberg
Copy link
Contributor Author

It seems codecov is installed in the virtualenv venv, but I'm using virtualenvwrapper to create and switch between virtualenvs, and this seems unsupported by the install script.

@forsberg forsberg changed the title Out of the box, ./scripts/tests fails due to missing codecov scripts/install script forces use of ./venv virtualenv, impossible to use with virtualenvwrapper Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forsberg