Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file): accept absolute paths #173

Merged
merged 1 commit into from
Jun 18, 2022
Merged

fix(file): accept absolute paths #173

merged 1 commit into from
Jun 18, 2022

Conversation

favonia
Copy link
Owner

@favonia favonia commented Jun 18, 2022

Closes #172.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #173 (b27ac56) into main (2fa8268) will decrease coverage by 0.16%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   83.48%   83.31%   -0.17%     
==========================================
  Files          27       27              
  Lines        1568     1576       +8     
==========================================
+ Hits         1309     1313       +4     
- Misses        254      257       +3     
- Partials        5        6       +1     
Flag Coverage Δ
unittests 83.31% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/file/file.go 73.33% <50.00%> (-26.67%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@favonia favonia merged commit 79bcd9b into main Jun 18, 2022
@favonia favonia deleted the absolute-paths branch June 18, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: can't work with Docker secrets
1 participant