Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): robust splitter for domains #42

Merged
merged 3 commits into from
Jul 26, 2021
Merged

fix(api): robust splitter for domains #42

merged 3 commits into from
Jul 26, 2021

Conversation

favonia
Copy link
Owner

@favonia favonia commented Jul 26, 2021

Several extreme cases to consider:

  1. Domains which are not UTF-8-encoded.
  2. Domains which are doubly Punycode-encoded.
  3. Domains which have empty labels and/or the trailing period.

@favonia favonia merged commit 12648db into main Jul 26, 2021
@favonia favonia deleted the fix-unicode-domain branch July 26, 2021 12:31
@favonia favonia linked an issue Jul 26, 2021 that may be closed by this pull request
Use runes when splitting subdomains/zones #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use runes when splitting subdomains/zones
1 participant
@favonia