-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to whitelist exceptions #15
Comments
I think there is no legit execptions. Every exception will terminate process. I think when you code throws exceptions at runtime is really bad. It means that something happened that you don't expect, and you should take care of it, not hide. With this feature you'll miss things that should never happened. |
My real usecase: What's the right solution? usecase # 2: getting record by ID. def show(conn, %{"photo_id" => photo_id}) do
photo = Repo.get!(Photo, photo_id)
...
Code is clear and self-describing. if photo is not found - fail, show error. but i do not want to see similar errors in the error tracker (in many cases endusers can try random ids etc) What's the right solution? |
I agree, I would like be able to ignore certain errors, esp 404s from bots |
I'm still not get it. Why you want to ignore exception instead of catch it and handle them ? In case of 404 you can make your own beautiful not found page. Of course we can't implement that, but application should work without throwing exceptions, because this is exceptions and should not accurs. Will loog at this RP once again later. |
Because with a 404 page it still send the error since |
What about |
No that does not work either |
Merged! |
Would be really useful,
e.g.
Ecto.NoResultsError
is totally legit exception that should not be tracked anyhowThe text was updated successfully, but these errors were encountered: