-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorize attaches properties to the String #6
Comments
(Got around this by duping the String, but figured I'd throw this here in case other people were having similar issues). |
Yep, another side-effect of this is it causes an exception to be raised when colorised is called on a frozen string. If you're going to monkey patch something like String, I would never create instance variables if I could at all avoid it. |
In class_parameters branch https://github.com/fazibear/colorize/tree/class_parameters, i moved colorize parameters to class variable. It should work in this case. |
New refactored version don't use any properties. |
Ruby 1.8.7 (2011-12-28 patchlevel 357) [universal-darwin11.0].
The text was updated successfully, but these errors were encountered: