Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_avg_successRate(person) is nonsensical #147

Open
RyanO-K opened this issue Mar 16, 2022 · 0 comments
Open

get_avg_successRate(person) is nonsensical #147

RyanO-K opened this issue Mar 16, 2022 · 0 comments

Comments

@RyanO-K
Copy link

RyanO-K commented Mar 16, 2022

Currently, get_avg_successRate returns 'curr_avg / len(photos)'. Curr_avg is a float given by the summation of all the photos success rates. However the photo success rates always sum to 1, so avg_successRate is just 1 / the number of photos a person has. As it stands this is useless and should be discarded, unless I am missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant