Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTK4 w/o X11 #11

Closed
concatime opened this issue Jan 24, 2022 · 5 comments
Closed

GTK4 w/o X11 #11

concatime opened this issue Jan 24, 2022 · 5 comments

Comments

@concatime
Copy link
Contributor

Hi, looking at CMakeLists.txt, it seems that X11 is a hard dependency. Can you provide a way to compile GTK4 feature w/o X11? Aka with wayland instead? That would be awesome.
Thank you.
@wengxt wengxt closed this as completed in 5f9b856 Jan 24, 2022
@wengxt
Copy link
Member

wengxt commented Jan 24, 2022

Can you try the fix and see if it works?

@concatime
Copy link
Contributor Author

Thank you for quickly diving in.
It does not work yet:

/build/fcitx5-gtk-c1323ce22f97540bc8b1f1426e6f98ff687a04da/gtk4/fcitximcontext.cpp:27:10: fatal error: 'xcb/xcb.h' file not found
#include <xcb/xcb.h>
         ^~~~~~~~~~~
1 error generated.

libxcb should only be used in an X11 environment.

@wengxt
Copy link
Member

wengxt commented Jan 26, 2022

Thanks, actually I didn't realize that I accidentally include that file.. it was not used anyway.

Can you try again?

@concatime
Copy link
Contributor Author

concatime commented Jan 26, 2022 •
edited
Loading

Can you merge #12 too, this way I can try master directly and not my own fork?

@concatime
Copy link
Contributor Author

concatime commented Jan 26, 2022 •
edited
Loading

All I can say for now is that it compiles successfully. Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wengxt @concatime